cc: Remove ScopedPtrDeque.

cc/base/container_util.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[danakj, 2015/11/13 19:54:02]

Can you move these to base/stl_util.h?

[vmpstr, 2015/11/13 23:15:38]

I was under the impression that code should live close to where its used. Also,
if we do switch this to std::move, this would introduce a library feature into
base header file which might break crashpad (at least that's my impression). 

I'd prefer to keep it here, but I can put it in base/ if you insist.

[danakj, 2015/11/13 23:41:06]

Crashpad will define new things in its own compat library. Calling new C++11
methods on existing classes is the problematic thing.

[vmpstr, 2015/11/13 23:50:49]

Ah OK. That makes sense. 

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_BASE_CONTAINER_UTIL_H_
+#define CC_BASE_CONTAINER_UTIL_H_
+
+#include "base/memory/scoped_ptr.h"
+
+namespace cc {
+
+template <typename Container>

[danakj, 2015/11/13 19:54:02]

please leave comments on these explaining what they do (explain reliance on move
cons/assignment etc

[vmpstr, 2015/11/13 23:15:38]

Done.

+typename Container::value_type TakeFront(Container* container) {
+  typename Container::value_type element = std::move(container->front());

[vmpstr, 2015/11/12 08:56:01]

Note that this is using std::move, to allow for non scoped ptr types as well. I
can change this to container->front().Pass() instead if that's better for now

[danakj, 2015/11/13 19:54:02]

Ya, you should use .Pass() and a TODO if you want to land this before we allow
move(). Up to you. The follow-up to switch back to move() would be easy (you can
TBR me on it if you do that).

[vmpstr, 2015/11/13 23:15:38]

Done.

+  container->pop_front();
+  return element;
+}
+
+template <typename Container>
+typename Container::value_type TakeBack(Container* container) {
+  typename Container::value_type element = std::move(container->back());
+  container->pop_back();
+  return element;
+}
+
+}  // namespace cc
+
+#endif  // CC_BASE_CONTAINER_UTIL_H_