Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1441603003: Cherry-pick upstream r252457 (Closed)

Created:
5 years, 1 month ago by Petr Hosek
Modified:
4 years, 10 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-libcxx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cherry-pick upstream r252457 Add initial support for the MUSL C library. Summary: This patch adds the LIBCXX_LIBC_IS_MUSL cmake option to allow the building of libcxx with the Musl C library. The option is necessary as Musl does not provide any predefined macro in order to test for its presence, like GLIBC. Most of the changes specify the correct path to choose through the various #if/#else constructs in the locale code. Depends on D13407. Reviewers: mclow.lists, jroelofs, EricWF Subscribers: jfb, tberghammer, danalbert, srhines, cfe-commits Differential Revision: http://reviews.llvm.org/D13673 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@252457 91177308-0d34-0410-b5e6-96231b3b80d8 BUG= https://code.google.com/p/nativeclient/issues/detail?id=4335 R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-libcxx.git;a=commit;h=91a5433c0c5e891098987276f3c6e98fe5c1b86a

Patch Set 1 #

Patch Set 2 : Use _LIBCPP_HAS_MUSL_LIBC directly instead of __musl__ #

Patch Set 3 : Add missing _LIBCPP_HAS_MUSL_LIBC check #

Patch Set 4 : Use __musl__ define to detect musl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -18 lines) Patch
M include/__config View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M include/__locale View 5 chunks +9 lines, -3 lines 0 comments Download
M include/locale View 1 2 1 chunk +1 line, -1 line 0 comments Download
A include/support/musl/xlocale.h View 1 chunk +58 lines, -0 lines 0 comments Download
M src/locale.cpp View 12 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Petr Hosek
PTAL, I haven't landed 1411403009 yet and I've just noticed that musl support was added ...
5 years, 1 month ago (2015-11-12 23:06:01 UTC) #3
Derek Schuff
On 2015/11/12 23:06:01, Petr Hosek wrote: > PTAL, I haven't landed 1411403009 yet and I've ...
5 years, 1 month ago (2015-11-13 06:32:29 UTC) #4
Petr Hosek
4 years, 10 months ago (2016-02-06 02:00:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
91a5433c0c5e891098987276f3c6e98fe5c1b86a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698