Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 1441603002: Revert of Fix accessibility issues in AudioPlayer and VideoPlayer. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
mtomasz, yawano
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix accessibility issues in AudioPlayer and VideoPlayer. (patchset #4 id:60001 of https://codereview.chromium.org/1415953006/ ) Reason for revert: We decided to punt redesign of audio player to M49. Original issue's description: > Fix accessibility issues in AudioPlayer and VideoPlayer. > > This CL includes: > - Make each control focusable. > - Implement blue outline for focused-by-keyboard buttons. > - Add aria-label for buttons and sliders. > - Extracted common behaviors of icon buttons as files-icon-button. > > BUG=551267, 533604 > TEST=manually tested using ChromeVox. > > Committed: https://crrev.com/11e80965386a3488f6ef9d4bb94722a4f5ba83f9 > Cr-Commit-Position: refs/heads/master@{#359041} TBR=yawano@chromium.org,mtomasz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551267, 533604 Committed: https://crrev.com/b80b21af601044b3322a8012e8df3707b9e32b27 Cr-Commit-Position: refs/heads/master@{#359281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -356 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +0 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 4 chunks +0 lines, -32 lines 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.html View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.css View 4 chunks +48 lines, -13 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.html View 2 chunks +61 lines, -37 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 3 chunks +9 lines, -35 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/file_manager/file_manager/foreground/elements/files_icon_button.html View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/file_manager/file_manager/foreground/elements/files_icon_button.js View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/open_audio_files.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 4 chunks +9 lines, -14 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 13 chunks +13 lines, -58 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 6 chunks +19 lines, -6 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
fukino
Created Revert of Fix accessibility issues in AudioPlayer and VideoPlayer.
5 years, 1 month ago (2015-11-12 08:15:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441603002/1
5 years, 1 month ago (2015-11-12 08:16:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 08:17:23 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:05:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b80b21af601044b3322a8012e8df3707b9e32b27
Cr-Commit-Position: refs/heads/master@{#359281}

Powered by Google App Engine
This is Rietveld 408576698