Sync online wallpaper

chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var WALLPAPER_PICKER_WIDTH = 574;
 var WALLPAPER_PICKER_HEIGHT = 420;
 
 var wallpaperPickerWindow;
 
 var surpriseWallpaper = null;
@@ skipping 18 matching lines @@
  */
 SurpriseWallpaper.prototype.tryChangeWallpaper = function() {
   var self = this;
   var onFailure = function() {
     self.retryLater_();
     self.fallbackToLocalRss_();
   };
   // Try to fetch newest rss as document from server first. If any error occurs,
   // proceed with local copy of rss.
   WallpaperUtil.fetchURL(Constants.WallpaperRssURL, 'document', function(xhr) {
-    WallpaperUtil.saveToLocalStorage(Constants.AccessRssKey,
-        new XMLSerializer().serializeToString(xhr.responseXML));
+    WallpaperUtil.saveToStorage(Constants.AccessRssKey,
+        new XMLSerializer().serializeToString(xhr.responseXML), false);
     self.updateSurpriseWallpaper(xhr.responseXML);
   }, onFailure);
 };
 
 /**
  * Retries changing the wallpaper 1 hour later. This is called when fetching the
  * rss or wallpaper from server fails.
  * @private
  */
 SurpriseWallpaper.prototype.retryLater_ = function() {
@@ skipping 81 matching lines @@
 SurpriseWallpaper.prototype.setRandomWallpaper_ = function(dateString) {
   var self = this;
   Constants.WallpaperLocalStorage.get(Constants.AccessManifestKey,
                                       function(items) {
     var manifest = items[Constants.AccessManifestKey];
     if (manifest) {
       var index = Math.floor(Math.random() * manifest.wallpaper_list.length);
       var wallpaper = manifest.wallpaper_list[index];
       var wallpaperURL = wallpaper.base_url + Constants.HighResolutionSuffix;
       var onSuccess = function() {
-        WallpaperUtil.saveToLocalStorage(
-            Constants.AccessLastSurpriseWallpaperChangedDate, dateString);
+        WallpaperUtil.saveToStorage(
+            Constants.AccessLastSurpriseWallpaperChangedDate,
+            dateString,
+            false);
       }
       WallpaperUtil.setOnlineWallpaper(wallpaperURL, wallpaper.default_layout,
           onSuccess, self.retryLater_.bind(self));
     }
   });
 };
 
 /**
  * Sets wallpaper to the wallpaper specified by item from rss. If downloading
  * the wallpaper fails, retry one hour later.
@@ skipping 19 matching lines @@
     }
   }, onFailure);
 };
 
 /**
  * Disables the wallpaper surprise me feature. Clear all alarms and states.
  */
 SurpriseWallpaper.prototype.disable = function() {
   chrome.alarms.clearAll();
   // Makes last changed date invalid.
-  WallpaperUtil.saveToLocalStorage(
-      Constants.AccessLastSurpriseWallpaperChangedDate, '');
+  WallpaperUtil.saveToStorage(Constants.AccessLastSurpriseWallpaperChangedDate,
+                              '', false);
 };
 
 /**
  * Changes current wallpaper and sets up an alarm to schedule next change around
  * midnight.
  */
 SurpriseWallpaper.prototype.next = function() {
   var nextUpdate = this.nextUpdateTime(new Date());
   chrome.alarms.create({when: nextUpdate});
   this.tryChangeWallpaper();
@@ skipping 35 matching lines @@
 });
 
 chrome.storage.onChanged.addListener(function(changes, namespace) {
   if (changes[Constants.AccessSurpriseMeEnabledKey]) {
     if (changes[Constants.AccessSurpriseMeEnabledKey].newValue) {
       SurpriseWallpaper.getInstance().next();
     } else {
       SurpriseWallpaper.getInstance().disable();
     }
   }
+
+  if (changes[Constants.AccessSyncWallpaperInfoKey]) {
+    var newValue = changes[Constants.AccessSyncWallpaperInfoKey].newValue;
+    Constants.WallpaperLocalStorage.get(Constants.AccessLocalWallpaperInfoKey,
+                                        function(items) {
+      // Normally, the wallpaper info saved in local storage and sync storage
+      // are the same. If the synced value changed by sync service, they may
+      // different. In that case, change wallpaper to the one saved in sync
+      // storage and update the local value.
+      var localValue = items[Constants.AccessLocalWallpaperInfoKey];
+      if (localValue == undefined ||
+          localValue.url != newValue.url ||
+          localValue.layout != newValue.layout ||
+          localValue.source != localValue.source) {

[flackr, 2013/04/26 17:03:57]

localValue.source will always be equal to localValue.source :-)

[bshe, 2013/04/26 17:34:48]

Dooh. Forget to commit and upload my local patch... Thanks!


On 2013/04/26 17:03:57, flackr wrote:

+        if (newValue.source == Constants.WallpaperSourceEnum.Online) {
+          // TODO(bshe): Consider schedule an alarm to set online wallpaper
+          // later when failed. Note that we need to cancel the retry if user
+          // set another wallpaper before retry alarm invoked.
+          WallpaperUtil.setOnlineWallpaper(newValue.url, newValue.layout,
+            function() {}, function() {});
+        }
+        WallpaperUtil.saveToStorage(Constants.AccessLocalWallpaperInfoKey,
+                                    newValue, false);
+      }
+    });
+  }
 });
 
 chrome.alarms.onAlarm.addListener(function() {
   SurpriseWallpaper.getInstance().next();
 });