Sync online wallpaper

Sync online wallpaper

Note: surprise me option is not synced yet


BUG=179276
TEST= (need chromebook)
1. open wallpaper picker, set any of the online wallpapers (remember the one you select)
2. go to chrome://sync, in the "sync node browser" tab, drill down to "app settings" in the left tree view
3. select "wallpaper-info-key" item. skim over the detail, you should see the wallpaper url is remembered.
4. logout and delete your account and then login or login on a diffrent device (make sure sync trigged).
5. your wallpaper should automatically change from default wallpaper to the one you previously selected in a moment after login

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199838

[bshe, 2013-04-25 16:50:50]

Hey Rob. Could you please take a look at this small CL?

This is the first piece that sync user's online wallpaper preference.

The "surprise me" option is not synced yet and will be take care in a seperate
CL.

Thanks!

[flackr, 2013-04-26 03:51:16]

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
(right):

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:241: } else
if (changes[Constants.AccessWallpaperInfoKey]) {
This shouldn't be else if, just if. Both keys may have changed.

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:245: if
(oldValue == undefined &&
Why only if oldValue is undefined? I think it would be nice to have a change on
one computer change the wallpapers on the other computers.

[bshe, 2013-04-26 16:56:51]

Done. Could you please take another look? Thanks!

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
(right):

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:241: } else
if (changes[Constants.AccessWallpaperInfoKey]) {
On 2013/04/26 03:51:16, flackr wrote:
> This shouldn't be else if, just if. Both keys may have changed.

Done.

https://codereview.chromium.org/14416017/diff/1005/chrome/browser/resources/c...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:245: if
(oldValue == undefined &&
You are right. It doesn't handle the case you mention.

I wasn't able to find a easy way to detect if the value is changed because of
sync or user action. But after spend more time on it, it seems we can use an
extra local value to easily distinguish the two cases.

On 2013/04/26 03:51:16, flackr wrote:
> Why only if oldValue is undefined? I think it would be nice to have a change
on
> one computer change the wallpapers on the other computers.

[flackr, 2013-04-26 17:03:57]

https://codereview.chromium.org/14416017/diff/11001/chrome/browser/resources/...
File chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
(right):

https://codereview.chromium.org/14416017/diff/11001/chrome/browser/resources/...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:255:
localValue.source != localValue.source) {
localValue.source will always be equal to localValue.source :-)

[bshe, 2013-04-26 17:34:48]

Done. Thanks!

https://codereview.chromium.org/14416017/diff/11001/chrome/browser/resources/...
File chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
(right):

https://codereview.chromium.org/14416017/diff/11001/chrome/browser/resources/...
chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js:255:
localValue.source != localValue.source) {
Dooh. Forget to commit and upload my local patch... Thanks!


On 2013/04/26 17:03:57, flackr wrote:
> localValue.source will always be equal to localValue.source :-)

[flackr, 2013-04-26 17:49:16]

LGTM, it's probably worth noting the current behavior when you set a custom
wallpaper in a comment. If I read correctly, it just won't update your sync
wallpaper setting so your other computers will continue to use the last online
wallpaper you set.

[commit-bot: I haz the power, 2013-05-13 18:26:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/14416017/28001

[commit-bot: I haz the power, 2013-05-13 22:37:55]

Change committed as 199838