sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 14416014: After a dynamic call, refine the receiver type by looking at the potential targets of that call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 14416014: After a dynamic call, refine the receiver type by looking at the potential targets of that call. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 22031)

+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)

@@ -667,8 +667,16 @@

}

HInstruction receiver = node.getDartReceiver(compiler);

Element field = findConcreteFieldForDynamicAccess(receiver, node.selector);

- if (field == null) return node;

- return directFieldGet(receiver, field);

+ if (field != null) return directFieldGet(receiver, field);

+ Selector selector = node.selector;

+ if (node.dependsOnSomething()

+ && compiler.resolverWorld.onlyReachesFinalFields(selector, compiler)) {

+ // If we know all potential targets are final fields, or fields

+ // that are never assigned twice, we know this getter does not

+ // depend on anything.

+ node.clearAllDependencies();

+ }

+ return node;

}

HInstruction directFieldGet(HInstruction receiver, Element field) {