src/full-codegen.cc - Issue 14416011: Fix yield inside with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 14416011: Fix yield inside with (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Add assertion Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 81f4c1d4b0bc5e2f11b720ef5158c7bfd0c29451..dc646b1a98c88c1192730be5b2d6e9e6d7e36d14 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1255,9 +1255,12 @@ void FullCodeGenerator::VisitWithStatement(WithStatement* stmt) {

__ CallRuntime(Runtime::kPushWithContext, 2);

StoreToFrameField(StandardFrameConstants::kContextOffset, context_register());

+ Scope* saved_scope = scope();

+ scope_ = stmt->scope();

{ WithOrCatch body(this);

Visit(stmt->statement());

}

+ scope_ = saved_scope;

// Pop context.

LoadContextField(context_register(), Context::PREVIOUS_INDEX);

« no previous file with comments | « src/ast.h ('k') | src/parser.cc » ('j') | no next file with comments »