Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: src/heap.cc

Issue 14416010: Prevent false positive from GCMole in DeferredFormatStackTrace. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7678 matching lines...) Expand 10 before | Expand all | Expand 10 after
7689 // Check whether the stack property is backed by the original getter. 7689 // Check whether the stack property is backed by the original getter.
7690 LookupResult lookup(isolate); 7690 LookupResult lookup(isolate);
7691 JSObject::cast(object)->LocalLookupRealNamedProperty(*stack_key, &lookup); 7691 JSObject::cast(object)->LocalLookupRealNamedProperty(*stack_key, &lookup);
7692 if (!lookup.IsFound() || lookup.type() != CALLBACKS) continue; 7692 if (!lookup.IsFound() || lookup.type() != CALLBACKS) continue;
7693 Object* callback = lookup.GetCallbackObject(); 7693 Object* callback = lookup.GetCallbackObject();
7694 if (!callback->IsAccessorPair()) continue; 7694 if (!callback->IsAccessorPair()) continue;
7695 Object* getter_obj = AccessorPair::cast(callback)->getter(); 7695 Object* getter_obj = AccessorPair::cast(callback)->getter();
7696 if (!getter_obj->IsJSFunction()) continue; 7696 if (!getter_obj->IsJSFunction()) continue;
7697 getter_fun = JSFunction::cast(getter_obj); 7697 getter_fun = JSFunction::cast(getter_obj);
7698 String* key = isolate->heap()->hidden_stack_trace_string(); 7698 String* key = isolate->heap()->hidden_stack_trace_string();
7699 if (key != getter_fun->GetHiddenProperty(key)) continue; 7699 Object* value = getter_fun->GetHiddenProperty(key);
7700 if (key != value) continue;
7700 } 7701 }
7701 7702
7702 budget--; 7703 budget--;
7703 HandleScope scope(isolate); 7704 HandleScope scope(isolate);
7704 bool has_exception = false; 7705 bool has_exception = false;
7705 #ifdef DEBUG 7706 #ifdef DEBUG
7706 Handle<Map> map(HeapObject::cast(object)->map(), isolate); 7707 Handle<Map> map(HeapObject::cast(object)->map(), isolate);
7707 #endif 7708 #endif
7708 Handle<Object> object_handle(object, isolate); 7709 Handle<Object> object_handle(object, isolate);
7709 Handle<Object> getter_handle(getter_fun, isolate); 7710 Handle<Object> getter_handle(getter_fun, isolate);
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
7860 static_cast<int>(object_sizes_last_time_[index])); 7861 static_cast<int>(object_sizes_last_time_[index]));
7861 FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(ADJUST_LAST_TIME_OBJECT_COUNT) 7862 FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(ADJUST_LAST_TIME_OBJECT_COUNT)
7862 #undef ADJUST_LAST_TIME_OBJECT_COUNT 7863 #undef ADJUST_LAST_TIME_OBJECT_COUNT
7863 7864
7864 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_)); 7865 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_));
7865 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_)); 7866 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_));
7866 ClearObjectStats(); 7867 ClearObjectStats();
7867 } 7868 }
7868 7869
7869 } } // namespace v8::internal 7870 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698