Issue 1441563002: Merge to XFA: Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1441563002: Merge to XFA: Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to access the source components as if |m_bpc| == 8. Even when it fell into the codepath that tried to do the right thing in this case, it was wrong. BUG=554151 TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec Review URL: https://codereview.chromium.org/1433423002 . (cherry picked from commit e21fe98d5b5da7da01503b985b07b90c8e811689) Committed: https://pdfium.googlesource.com/pdfium/+/46bed62931ffc9e482525de4525a6e54043c6899

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -36 lines)			Patch
M	BUILD.gn	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	6 chunks	+38 lines, -29 lines	0 comments	Download
A +	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	testing/resources/bug_554151.in	View	1 chunk	+59 lines, -0 lines	0 comments	Download
A	testing/resources/bug_554151.pdf	View	1 chunk	+70 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Oliver Chang

5 years, 1 month ago (2015-11-12 00:41:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46bed62931ffc9e482525de4525a6e54043c6899 (presubmit successful).