third_party/WebKit/Source/web/tests/MHTMLTest.cpp - Issue 1441553002: Generating CIDs in Blink during MHTML serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

Issue 1441553002: Generating CIDs in Blink during MHTML serialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-per-frame-page-serializer-only

Patch Set: Using references for out parameters in Blink. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebPageSerializer.cpp ('K') | « third_party/WebKit/Source/web/WebPageSerializer.cpp ('k') | third_party/WebKit/Source/web/tests/PageSerializerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

index a7ca20fe2adf7095b07a691f3dbe92ed2d6d8878..4aef940df81f40b738d5ec6c44bc58cd258cbe92 100644

--- a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

+++ b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

@@ -151,7 +151,7 @@ protected:

MHTMLArchive::generateMHTMLHeader(boundary, title, mimeType, *mhtmlData);

for (const auto& resource : resources) {

MHTMLArchive::generateMHTMLPart(

- boundary, encodingPolicy, resource, *mhtmlData);

+ boundary, String(), encodingPolicy, resource, *mhtmlData);

}

MHTMLArchive::generateMHTMLFooter(boundary, *mhtmlData);

return mhtmlData.release();