third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h - Issue 1441553002: Generating CIDs in Blink during MHTML serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

Issue 1441553002: Generating CIDs in Blink during MHTML serialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-per-frame-page-serializer-only

Patch Set: Addressed more CR feedback from yosin@. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mhtml/ArchiveResourceCollection.cpp ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp » ('j') | third_party/WebKit/Source/web/WebPageSerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

index c1c93722647626deb741080236ed192711943f6d..5479438dec086cec56306e35bbab4b429c7377ac 100644

--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

@@ -77,8 +77,12 @@ public:

// Same |boundary| needs to used for all generateMHTMLHeader and

// generateMHTMLPart and generateMHTMLFooter calls that belong to the same

// MHTML document (see also generateMHTMLBoundary method).

+ //

+ // If |contentID| is non-empty, then it will be used as a Content-ID header.

+ // See rfc2557 - section 8.3 - "Use of the Content-ID header and CID URLs".

static void generateMHTMLPart(

- const String& boundary, EncodingPolicy, const SerializedResource&,

+ const String& boundary, const String& contentID,

+ EncodingPolicy, const SerializedResource&,

SharedBuffer& outputBuffer);

// Generates an MHTML footer and appends it to |outputBuffer|.