Generating CIDs in Blink during MHTML serialization.

third_party/WebKit/Source/web/tests/PageSerializerTest.cpp

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 38 matching lines @@
 #include "web/WebViewImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 #include "wtf/Assertions.h"
 #include "wtf/Vector.h"
 
 using blink::URLTestHelpers::toKURL;
 using blink::URLTestHelpers::registerMockedURLLoad;
 
 namespace blink {
 
-class PageSerializerTest : public testing::Test {
+class PageSerializerTest
+    : public testing::Test
+    , public PageSerializer::Delegate {
 public:
     PageSerializerTest()
         : m_folder(WebString::fromUTF8("pageserializer/"))
         , m_baseUrl(toKURL("http://www.test.com"))
     {
     }
 
 protected:
     void SetUp() override
     {
@@ skipping 41 matching lines @@
     }
 
     void registerRewriteURL(const char* fromURL, const char* toURL)
     {
         m_rewriteURLs.add(fromURL, toURL);
     }
 
     void serialize(const char* url)
     {
         FrameTestHelpers::loadFrame(m_helper.webView()->mainFrame(), KURL(m_baseUrl, url).string().utf8().data());
-        PageSerializer serializer(&m_resources, nullptr);
-
-        serializer.setRewriteURLFolder(m_rewriteFolder);
-        for (const auto& rewriteURL: m_rewriteURLs)
-            serializer.registerRewriteURL(rewriteURL.key, rewriteURL.value);
-
+        PageSerializer serializer(m_resources, this);
         Frame* frame = m_helper.webViewImpl()->mainFrameImpl()->frame();
         for (; frame; frame = frame->tree().traverseNext()) {
             // This is safe, because tests do not do cross-site navigation
             // (and therefore don't have remote frames).
             serializer.serializeFrame(*toLocalFrame(frame));
         }
     }
 
     Vector<SerializedResource>& getResources()
     {
@@ skipping 27 matching lines @@
     }
 
 private:
     static void configureSettings(WebSettings* settings)
     {
         settings->setImagesEnabled(true);
         settings->setLoadsImagesAutomatically(true);
         settings->setJavaScriptEnabled(true);
     }
 
+    // PageSerializer::Delegate implementation.
+    bool shouldIgnoreAttribute(const Attribute&) override
+    {
+        return false;
+    }
+
+    // PageSerializer::Delegate implementation.
+    bool rewriteLink(const Element& element, String& rewrittenLink)
+    {
+        String completeURL;
+        for (const auto& attribute : element.attributes()) {
+            if (element.hasLegalLinkAttribute(attribute.name())) {
+                completeURL = element.document().completeURL(attribute.value());
+                break;
+            }
+        }
+
+        if (completeURL.isNull() || !m_rewriteURLs.contains(completeURL))
+            return false;
+
+        StringBuilder uriBuilder;
+        uriBuilder.append(m_rewriteFolder);
+        uriBuilder.appendLiteral("/");
+        uriBuilder.append(m_rewriteURLs.get(completeURL));
+        rewrittenLink = uriBuilder.toString();
+        return true;
+    }
+
     FrameTestHelpers::WebViewHelper m_helper;
     WebString m_folder;
     KURL m_baseUrl;
     Vector<SerializedResource> m_resources;
     HashMap<String, String> m_rewriteURLs;
     String m_rewriteFolder;
 };
 
 TEST_F(PageSerializerTest, HTMLElements)
 {
@@ skipping 75 matching lines @@
     registerURL("embed_iframe.html", "text/html");
     registerURL("encoded_iframe.html", "text/html");
 
     registerURL("top.png", "image.png", "image/png");
     registerURL("simple.png", "image.png", "image/png");
     registerURL("object.png", "image.png", "image/png");
     registerURL("embed.png", "image.png", "image/png");
 
     serialize("top_frame.html");
 
-    EXPECT_EQ(9U, getResources().size());
+    EXPECT_EQ(10U, getResources().size());
 
     EXPECT_TRUE(isSerialized("top_frame.html", "text/html"));
-    EXPECT_TRUE(isSerialized("simple_iframe.html", "text/html"));
+    EXPECT_TRUE(isSerialized("simple_iframe.html", "text/html")); // Twice.
     EXPECT_TRUE(isSerialized("object_iframe.html", "text/html"));
     EXPECT_TRUE(isSerialized("embed_iframe.html", "text/html"));
     EXPECT_TRUE(isSerialized("encoded_iframe.html", "text/html"));
 
     EXPECT_TRUE(isSerialized("top.png", "image/png"));
     EXPECT_TRUE(isSerialized("simple.png", "image/png"));
     EXPECT_TRUE(isSerialized("object.png", "image/png"));
     EXPECT_TRUE(isSerialized("embed.png", "image/png"));
 
     // Ensure that page contents are not NFC-normalized before encoding.
@@ skipping 13 matching lines @@
     registerURL("orange_background.png", "image.png", "image/png");
     registerURL("blue_background.png", "image.png", "image/png");
 
     serialize("blank_frames.html");
 
     EXPECT_EQ(7U, getResources().size());
 
     EXPECT_TRUE(isSerialized("http://www.test.com/red_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("http://www.test.com/orange_background.png", "image/png"));
     EXPECT_TRUE(isSerialized("http://www.test.com/blue_background.png", "image/png"));
-    // The blank frames should have got a magic URL.
-    EXPECT_TRUE(isSerialized("wyciwyg://frame/0", "text/html"));
-    EXPECT_TRUE(isSerialized("wyciwyg://frame/1", "text/html"));
-    EXPECT_TRUE(isSerialized("wyciwyg://frame/2", "text/html"));
+
+    // The blank frames no longer get magic URL (i.e. wyciwyg://frame/0), so we
+    // can't really assert their presence via URL.  We also can't use content-id
+    // in assertions (since it is not deterministic).  Therefore we need to rely
+    // on getResources().size() assertion above and on browser-level tests
+    // (i.e. SavePageMultiFrameBrowserTest.AboutBlank).
 }
 
 TEST_F(PageSerializerTest, CSS)
 {
     setBaseFolder("pageserializer/css/");
 
     registerURL("css_test_page.html", "text/html");
     registerURL("link_styles.css", "text/css");
     registerURL("encoding.css", "text/css");
     registerURL("import_style_from_link.css", "text/css");
@@ skipping 130 matching lines @@
     registerRewriteURL("http://www.test.com/absolute.png", "a.png");
     registerRewriteURL("http://www.test.com/relative.png", "b.png");
 
     serialize("rewritelinks_simple.html");
 
     EXPECT_EQ(3U, getResources().size());
     EXPECT_NE(getSerializedData("rewritelinks_simple.html", "text/html").find("\"folder/a.png\""), kNotFound);
     EXPECT_NE(getSerializedData("rewritelinks_simple.html", "text/html").find("\"folder/b.png\""), kNotFound);
 }
 
-TEST_F(PageSerializerTest, RewriteLinksBase)
-{
-    setBaseFolder("pageserializer/rewritelinks/");
-    setRewriteURLFolder("folder");
-
-    registerURL("rewritelinks_base.html", "text/html");
-    registerURL("images/here/image.png", "image.png", "image/png");
-    registerURL("images/here/or/in/here/image.png", "image.png", "image/png");
-    registerURL("or/absolute.png", "image.png", "image/png");
-    registerRewriteURL("http://www.test.com/images/here/image.png", "a.png");
-    registerRewriteURL("http://www.test.com/images/here/or/in/here/image.png", "b.png");
-    registerRewriteURL("http://www.test.com/or/absolute.png", "c.png");
-
-    serialize("rewritelinks_base.html");
-
-    EXPECT_EQ(4U, getResources().size());
-    EXPECT_NE(getSerializedData("rewritelinks_base.html", "text/html").find("\"folder/a.png\""), kNotFound);
-    EXPECT_NE(getSerializedData("rewritelinks_base.html", "text/html").find("\"folder/b.png\""), kNotFound);
-    EXPECT_NE(getSerializedData("rewritelinks_base.html", "text/html").find("\"folder/c.png\""), kNotFound);
-}
-
 // Test that we don't regress https://bugs.webkit.org/show_bug.cgi?id=99105
 TEST_F(PageSerializerTest, SVGImageDontCrash)
 {
     setBaseFolder("pageserializer/svg/");
 
     registerURL("page_with_svg_image.html", "text/html");
     registerURL("green_rectangle.svg", "image/svg+xml");
 
     serialize("page_with_svg_image.html");
 
@@ skipping 35 matching lines @@
     EXPECT_EQ("saved from url=(0015)http://foo.com/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com")));
     EXPECT_EQ("saved from url=(0015)http://f-o.com/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://f-o.com")));
     EXPECT_EQ("saved from url=(0019)http://foo.com-%2D/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com--")));
     EXPECT_EQ("saved from url=(0024)http://f-%2D.com-%2D%3E/", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://f--.com-->")));
     EXPECT_EQ("saved from url=(0020)http://foo.com/?-%2D", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com?--")));
     EXPECT_EQ("saved from url=(0020)http://foo.com/#-%2D", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#--")));
     EXPECT_EQ("saved from url=(0026)http://foo.com/#bar-%2Dbaz", PageSerializer::markOfTheWebDeclaration(KURL(ParsedURLString, "http://foo.com#bar--baz")));
 }
 
 } // namespace blink