Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2399)

Unified Diff: base/win/registry.h

Issue 1441543002: Make vector_as_array use std::vector::data and switch a few directories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/win/registry.h
diff --git a/base/win/registry.h b/base/win/registry.h
index c3e015b3bf0e59636e26b9a5a58b4b147df729b1..83f354d0b6d6dfb0b6f3cc3459e0f628eef10459 100644
--- a/base/win/registry.h
+++ b/base/win/registry.h
@@ -11,7 +11,6 @@
#include "base/base_export.h"
#include "base/basictypes.h"
-#include "base/stl_util.h"
#include "base/win/object_watcher.h"
#include "base/win/scoped_handle.h"
@@ -180,7 +179,7 @@ class BASE_EXPORT RegistryValueIterator {
void operator++();
const wchar_t* Name() const { return name_.c_str(); }
- const wchar_t* Value() const { return vector_as_array(&value_); }
+ const wchar_t* Value() const { return value_.data(); }
danakj 2015/11/14 00:39:01 use &*begin() here with a TODO to use data() point
davidben 2015/11/16 21:27:38 Done, but with the check for .empty()
danakj 2015/11/16 21:38:37 Sounds like you can just use data() here too from
davidben 2015/11/16 21:55:37 Done.
// ValueSize() is in bytes.
DWORD ValueSize() const { return value_size_; }
DWORD Type() const { return type_; }

Powered by Google App Engine
This is Rietveld 408576698