Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: net/android/network_library.cc

Issue 144153002: Follow-up changes to Android certificate verification logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and fix X509UtilTest. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/android/javatests/src/org/chromium/net/X509UtilTest.java ('k') | net/cert/cert_verify_proc_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/network_library.cc
diff --git a/net/android/network_library.cc b/net/android/network_library.cc
index 37ab18e6f4a35c86b59e9583424c9aa1f657d05f..ea9ec4a44a7979f098d14b3b2f090346ecfddfe1 100644
--- a/net/android/network_library.cc
+++ b/net/android/network_library.cc
@@ -12,7 +12,6 @@
#include "jni/AndroidNetworkLibrary_jni.h"
using base::android::AttachCurrentThread;
-using base::android::ClearException;
using base::android::ConvertJavaStringToUTF8;
using base::android::ConvertUTF8ToJavaString;
using base::android::GetApplicationContext;
@@ -46,10 +45,6 @@ void VerifyX509CertChain(const std::vector<std::string>& cert_chain,
ScopedJavaLocalRef<jobject> result =
Java_AndroidNetworkLibrary_verifyServerCertificates(
env, chain_byte_array.obj(), auth_string.obj(), host_string.obj());
- if (ClearException(env)) {
- *status = android::VERIFY_FAILED;
- return;
- }
ExtractCertVerifyResult(result.obj(),
status, is_issued_by_known_root, verified_chain);
« no previous file with comments | « net/android/javatests/src/org/chromium/net/X509UtilTest.java ('k') | net/cert/cert_verify_proc_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698