net/cert/cert_verify_proc_android.cc - Issue 144153002: Follow-up changes to Android certificate verification logic.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/cert_verify_proc_android.cc

Issue 144153002: Follow-up changes to Android certificate verification logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and fix X509UtilTest. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/cert/cert_verify_proc_android.h"	5 #include "net/cert/cert_verify_proc_android.h"

6	6

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 126 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
137 std::vector<std::string> cert_bytes;	137 std::vector<std::string> cert_bytes;

138 if (!GetChainDEREncodedBytes(cert, &cert_bytes))	138 if (!GetChainDEREncodedBytes(cert, &cert_bytes))

139 return ERR_CERT_INVALID;	139 return ERR_CERT_INVALID;

140 if (!VerifyFromAndroidTrustManager(cert_bytes, hostname, verify_result)) {	140 if (!VerifyFromAndroidTrustManager(cert_bytes, hostname, verify_result)) {

141 NOTREACHED();	141 NOTREACHED();

142 return ERR_FAILED;	142 return ERR_FAILED;

143 }	143 }

144 if (IsCertStatusError(verify_result->cert_status))	144 if (IsCertStatusError(verify_result->cert_status))

145 return MapCertStatusToNetError(verify_result->cert_status);	145 return MapCertStatusToNetError(verify_result->cert_status);

146	146

147 // TODO(ppi): Implement missing functionality: yielding the constructed trust

148 // chain, public key hashes of its certificates and \|is_issued_by_known_root\|

149 // flag. All of the above require specific support from the platform, missing

150 // in the Java APIs. See also: http://crbug.com/116838

151

152 return OK;	147 return OK;

153 }	148 }

154	149

155 } // namespace net	150 } // namespace net

OLD	NEW

« no previous file with comments | « net/android/network_library.cc ('k') | net/cert/x509_util_android.cc » ('j') | no next file with comments »