Add switch for alternative upload locations.

Add switch for alternative upload locations.

BUG=
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a3b5f0ea5294fbf05a31af4dad51efb015153a5f

[dcar, 2015-11-13 04:55:35]

Description was changed from

==========
Add switch for alternative upload locations.

BUG=
==========

to

==========
Add switch for alternative upload locations.

BUG=
==========

[dcar, 2015-11-13 04:55:35]

danielcar@google.com changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-11-13 06:23:20]

https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
File mojo/tools/upload_binaries.py (right):

https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
mojo/tools/upload_binaries.py:221: default="gs://mojo_infra/",
this changes the default from the current gs://mojo/ to gs://mojo_infra/.  We
can't do that until we also change all the download scripts and provide some
overlap for transitioning.  Could you leave the default gs://mojo/ and pass the
new value in explicitly?  (I expect us to get a new bucket to upload to that's
different from gs://mojo/ and gs://mojo_infra/ as soon as we can sort some
adminastrivia out)

[dcar, 2015-11-13 07:01:00]

On 2015/11/13 06:23:20, jamesr wrote:
>
https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
> File mojo/tools/upload_binaries.py (right):
> 
>
https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
> mojo/tools/upload_binaries.py:221: default="gs://mojo_infra/",
> this changes the default from the current gs://mojo/ to gs://mojo_infra/.  We
> can't do that until we also change all the download scripts and provide some
> overlap for transitioning.  Could you leave the default gs://mojo/ and pass
the
> new value in explicitly?  (I expect us to get a new bucket to upload to that's
> different from gs://mojo/ and gs://mojo_infra/ as soon as we can sort some
> adminastrivia out)

Done.

[dcar, 2015-11-13 07:03:54]

https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
File mojo/tools/upload_binaries.py (right):

https://codereview.chromium.org/1441483004/diff/20001/mojo/tools/upload_binar...
mojo/tools/upload_binaries.py:221: default="gs://mojo_infra/",
On 2015/11/13 06:23:20, jamesr wrote:
> this changes the default from the current gs://mojo/ to gs://mojo_infra/.  We
> can't do that until we also change all the download scripts and provide some
> overlap for transitioning.  Could you leave the default gs://mojo/ and pass
the
> new value in explicitly?  (I expect us to get a new bucket to upload to that's
> different from gs://mojo/ and gs://mojo_infra/ as soon as we can sort some
> adminastrivia out)

Done.

[jamesr, 2015-11-13 07:04:36]

lgtm w/ one suggestion.  after you fix that you should be able to land the patch
by running 'git cl land' so long as you're authenticated to github as 'dancard'

https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
File mojo/tools/upload_binaries.py (right):

https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
mojo/tools/upload_binaries.py:236: print config.values
delete this (i suspect it was intended just for local debugging)

[dcar, 2015-11-13 07:07:03]

https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
File mojo/tools/upload_binaries.py (right):

https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
mojo/tools/upload_binaries.py:236: print config.values
On 2015/11/13 07:04:36, jamesr wrote:
> delete this (i suspect it was intended just for local debugging)

Done.

[dcar, 2015-11-13 07:10:15]

On 2015/11/13 07:07:03, dcar wrote:
>
https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
> File mojo/tools/upload_binaries.py (right):
> 
>
https://codereview.chromium.org/1441483004/diff/40001/mojo/tools/upload_binar...
> mojo/tools/upload_binaries.py:236: print config.values
> On 2015/11/13 07:04:36, jamesr wrote:
> > delete this (i suspect it was intended just for local debugging)
> 
> Done.

remote: Permission to domokit/mojo.git denied to DanCard.

[dcar, 2015-11-13 07:15:22]

Committed patchset #4 (id:60001) manually as
a3b5f0ea5294fbf05a31af4dad51efb015153a5f (presubmit successful).