Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441423002: Rename LayoutItemImpl classes to LayoutItem. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Rename LayoutItemImpl classes to LayoutItem. There is no longer a LayoutItem/LayoutItemImpl distinction. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/419baf83d7fcf52fa535240bd0d020e39c91473f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -472 lines) Patch
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.h View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.h View 4 chunks +5 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.cpp View 10 chunks +14 lines, -13 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/common/xfa_doclayout.h View 3 chunks +28 lines, -32 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_layout_imp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_layout_imp.cpp View 4 chunks +15 lines, -13 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_appadapter.h View 1 chunk +32 lines, -32 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_appadapter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h View 7 chunks +17 lines, -17 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 52 chunks +142 lines, -153 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.h View 5 chunks +13 lines, -13 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp View 37 chunks +114 lines, -132 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.cpp View 9 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, nothing but sed.
5 years, 1 month ago (2015-11-13 18:22:28 UTC) #3
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-13 21:25:56 UTC) #4
Tom Sepez
5 years, 1 month ago (2015-11-13 21:28:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
419baf83d7fcf52fa535240bd0d020e39c91473f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698