Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 14414008: Fix an SkCommandLineFlags bug. (Closed)

Created:
7 years, 8 months ago by scroggo
Modified:
7 years, 8 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix an SkCommandLineFlags bug. Previously I was storing an SkTDArray of const char*, which fails if the strings go out of scope. Instead, store an SkTArray of SkString, and copy the strings, so we do not depend on the strings sticking around. Using an SkTArray because it is smart enough to call the destructors, so the copies can be destroyed on program exit. BUG=https://code.google.com/p/skia/issues/detail?id=1237 Committed: https://code.google.com/p/skia/source/detail?r=8829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommandLineFlags.h View 9 chunks +38 lines, -9 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
epoger@, this fixes the bug you saw where running without specifying --ignoreErrorTypes thought a help ...
7 years, 8 months ago (2013-04-22 22:40:06 UTC) #1
epoger
LGTM!
7 years, 8 months ago (2013-04-23 15:25:37 UTC) #2
scroggo
7 years, 8 months ago (2013-04-23 15:38:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698