Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc

Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc
index e6716ea9366d29f94e9084c9d62e75c7f6351b57..da6a7a443ed4b8e89f71074060a37bcf1fa1b323 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc
@@ -5,6 +5,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/test/histogram_tester.h"
#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
#include "components/page_load_metrics/common/page_load_metrics_messages.h"
@@ -230,3 +231,23 @@ TEST_F(PageLoadMetricsObserverTest, ReferralNotFromGWS) {
NavigateAndCommit(GURL("https://www.google.com"));
histogram_tester_.ExpectTotalCount(kHistogramNameFromGWSFirstTextPaint, 0);
}
+
+TEST_F(PageLoadMetricsObserverTest, IsGoogleCaptcha) {
+ struct {
+ std::string url;
+ bool expected;
+ } test_cases[] = {
+ {"", false},
+ {"http://www.google.com/", false},
+ {"http://www.cnn.com/", false},
+ {"http://ipv4.google.com/", false},
+ {"https://ipv4.google.com/sorry/IndexRedirect?continue=http://a", true},
+ {"https://ipv6.google.com/sorry/IndexRedirect?continue=http://a", true},
+ {"https://ipv7.google.com/sorry/IndexRedirect?continue=http://a", false},
+ };
+ for (const auto& test : test_cases) {
+ EXPECT_EQ(test.expected,
+ google_captcha_observer::IsGoogleCaptcha(GURL(test.url)))
+ << "for URL: " << test.url;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698