Chromium Code Reviews

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor cleanups Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: components/page_load_metrics/browser/page_load_metrics_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h
index d181d1420fe272ebf9c18e51616bf13927bca9ee..08a35dddc2fc226a29ea57a2e5b701983cda9031 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.h
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h
@@ -40,6 +40,11 @@ class PageLoadMetricsObserver {
public:
virtual ~PageLoadMetricsObserver() {}
+ // OnRedirect is triggered when a page load redirects to another URL.
+ // The navigation handle holds relevant data for the navigation, but will
+ // be destroyed soon after this call. Don't hold a reference to it.
+ virtual void OnRedirect(content::NavigationHandle* navigation_handle) {}
+
// OnCommit is triggered when a page load commits, i.e. when we receive the
// first data for the request. The navigation handle holds relevant data for
// the navigation, but will be destroyed soon after this call. Don't hold a

Powered by Google App Engine