components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing files (whoops) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc ('K') | « chrome/chrome_browser.gypi ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index 4a9e061a00a94cdb55701d37ebe20d12e894aca1..07937848bd69699c8b90c899374b624f15360e17 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -170,6 +170,7 @@ class PageLoadTracker {

rappor::RapporService* const rappor_service,

base::ObserverList<PageLoadMetricsObserver, true>* observers);

~PageLoadTracker();

+ void Redirect(content::NavigationHandle* navigation_handle);

void Commit(content::NavigationHandle* navigation_handle);

void WebContentsHidden();

void WebContentsShown();

@@ -239,6 +240,8 @@ class MetricsWebContentsObserver

content::NavigationHandle* navigation_handle) override;

void DidFinishNavigation(

content::NavigationHandle* navigation_handle) override;

+ void DidRedirectNavigation(

+ content::NavigationHandle* navigation_handle) override;

void WasShown() override;

void WasHidden() override;