chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing files (whoops) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 88858936ac74eabe9335ef50e51db0c72597a8ba..252b0090f00c5ddcdcf2772fac64cb5598fdd275 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"

#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"

#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"

#include "components/rappor/rappor_service.h"

#include "content/public/browser/web_contents.h"

@@ -18,6 +19,8 @@ void RegisterPageLoadMetricsObservers(

// This is a self-destruct class, and will delete itself when triggered by

// OnPageLoadMetricsGoingAway.

metrics->AddObserver(new FromGWSPageLoadMetricsObserver(metrics));

+ metrics->AddObserver(

+ new google_captcha_observer::GoogleCaptchaObserver(metrics));

}

} // namespace