tools/metrics/histograms/histograms.xml - Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1441393002: Add UMA to count the number of Google CAPTCHA pages shown and solved by users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed to using histogram, updated test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 4ee71d1be34b2cfc6f01bf37d6a6629de9ccaa62..102412ab8395778d80fb88eb6d6db2ea9ce34afb 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -14176,6 +14176,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>Http response codes in NetworkLocationRequest.</summary>

</histogram>

+<histogram name="GoogleCaptcha.Event" enum="GoogleCaptchaEvent">

Alexei Svitkine (slow) 2015/11/13 19:41:57 How about re-using the histogram name prefix that'

Matt Welsh 2015/11/13 20:15:19 Done.

+ <owner>mdw@chromium.org</owner>

+ <summary>Events related to Google CAPTCHA pages being seen by users.</summary>

+</histogram>

<owner>robliao@chromium.org</owner>

<owner>skare@chromium.org</owner>

@@ -62864,6 +62869,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</enum>

+<enum name="GoogleCaptchaEvent" type="int">

+ <int value="0" label="Google CAPTCHA shown"/>

+ <int value="1" label="Google CAPTCHA solved"/>

+</enum>

Represents a card type ID. See cardTypeId in