android_webview/browser/parent_output_surface.cc - Issue 1441273002: Android WebView: Crash on compositor context loss

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/parent_output_surface.cc

Issue 1441273002: Android WebView: Crash on compositor context loss (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't lose on memory Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/parent_output_surface.cc

diff --git a/android_webview/browser/parent_output_surface.cc b/android_webview/browser/parent_output_surface.cc

index 492316040ce7e0ff3ce75da3331d059d2d2abae8..fad7e5f0b073ef598d4e307eb94b3c6af9427adf 100644

--- a/android_webview/browser/parent_output_surface.cc

+++ b/android_webview/browser/parent_output_surface.cc

@@ -17,6 +17,11 @@ ParentOutputSurface::ParentOutputSurface(

ParentOutputSurface::~ParentOutputSurface() {

}

+void ParentOutputSurface::DidLoseOutputSurface() {

+ // Android WebView does not handle context loss.

+ LOG(FATAL) << "Render thread context loss";

void ParentOutputSurface::Reshape(const gfx::Size& size, float scale_factor) {

DCHECK_EQ(1.f, scale_factor);

surface_size_ = size;