Add AsLayoutItem()/ToLayoutItem() functions.

Add AsLayoutItem()/ToLayoutItem() functions.

Also protect the LayoutItem constructor, as !m_bIsContent
implies the object can be cast to the container class, so
ensure we don't make any of parent class.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ec441e67745054ece5e3d736b60fffa2f7f8d20c

[Tom Sepez, 2015-11-13 22:14:17]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-11-13 22:14:18]

Lei, next part of removing casts.

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp (left):

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp:1868: CXFA_LayoutItem* pChild
= pContainerItem->m_pFirstChild;
same increment in every path => should be "for"

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp:1903: for (CXFA_LayoutItem*
pChildLayoutItem = iterator.GetCurrent();
different increment in several paths => should be "while"

[Lei Zhang, 2015-11-13 22:30:32]

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/common/xfa...
File xfa/src/fxfa/src/common/xfa_doclayout.h (left):

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/common/xfa...
xfa/src/fxfa/src/common/xfa_doclayout.h:31: FX_BOOL IsContentLayoutItem() {
return m_bIsContentLayoutItem; }
You don't want to keep this for the callers that don't actually use the returned
pointer?

[Lei Zhang, 2015-11-13 22:38:26]

Otherwise LGTM

[Tom Sepez, 2015-11-13 22:45:50]

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/common/xfa...
File xfa/src/fxfa/src/common/xfa_doclayout.h (left):

https://codereview.chromium.org/1441243005/diff/1/xfa/src/fxfa/src/common/xfa...
xfa/src/fxfa/src/common/xfa_doclayout.h:31: FX_BOOL IsContentLayoutItem() {
return m_bIsContentLayoutItem; }
On 2015/11/13 22:30:31, Lei Zhang wrote:
> You don't want to keep this for the callers that don't actually use the
returned
> pointer?
Ok.  We kept this when Dan fixed CPDF_Object, so lets follow that pattern.

[Tom Sepez, 2015-11-13 22:46:58]

Committed patchset #3 (id:40001) manually as
ec441e67745054ece5e3d736b60fffa2f7f8d20c (presubmit successful).