Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 1441243002: Be more lenient about inspecting/pinging on invalid downloaded .zip's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust proto tag number to match server side. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This proto file includes: 5 // This proto file includes:
6 // (1) Client side phishing and malware detection request and response 6 // (1) Client side phishing and malware detection request and response
7 // protocol buffers. Those protocol messages should be kept in sync 7 // protocol buffers. Those protocol messages should be kept in sync
8 // with the server implementation. 8 // with the server implementation.
9 // 9 //
10 // (2) Safe Browsing reporting protocol buffers. 10 // (2) Safe Browsing reporting protocol buffers.
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 // extensions that get downloaded by users. 268 // extensions that get downloaded by users.
269 enum DownloadType { 269 enum DownloadType {
270 WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files. 270 WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files.
271 CHROME_EXTENSION = 1; // .crx files. 271 CHROME_EXTENSION = 1; // .crx files.
272 ANDROID_APK = 2; // .apk files. 272 ANDROID_APK = 2; // .apk files.
273 // .zip files containing one of the other executable types. 273 // .zip files containing one of the other executable types.
274 ZIPPED_EXECUTABLE = 3; 274 ZIPPED_EXECUTABLE = 3;
275 MAC_EXECUTABLE = 4; // .dmg, .pkg, etc. 275 MAC_EXECUTABLE = 4; // .dmg, .pkg, etc.
276 ZIPPED_ARCHIVE = 5; // .zip file containing another archive. 276 ZIPPED_ARCHIVE = 5; // .zip file containing another archive.
277 ARCHIVE = 6; // Archive that doesn't have a specific DownloadType. 277 ARCHIVE = 6; // Archive that doesn't have a specific DownloadType.
278 // A .zip that Chrome failed to unpack to the point of finding exe/zips.
279 INVALID_ZIP = 7;
280 // A .dmg, .pkg, etc, that Chrome failed to unpack to the point of finding
281 // Mach O's.
282 INVALID_MAC_ARCHIVE = 8;
278 } 283 }
279 optional DownloadType download_type = 10 [default = WIN_EXECUTABLE]; 284 optional DownloadType download_type = 10 [default = WIN_EXECUTABLE];
280 285
281 // Locale of the device, eg en, en_US. 286 // Locale of the device, eg en, en_US.
282 optional string locale = 11; 287 optional string locale = 11;
283 288
284 message PEImageHeaders { 289 message PEImageHeaders {
285 // IMAGE_DOS_HEADER. 290 // IMAGE_DOS_HEADER.
286 optional bytes dos_header = 1; 291 optional bytes dos_header = 1;
287 // IMAGE_FILE_HEADER. 292 // IMAGE_FILE_HEADER.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 optional Digests digests = 3; 348 optional Digests digests = 3;
344 optional int64 length = 4; 349 optional int64 length = 4;
345 optional SignatureInfo signature = 5; 350 optional SignatureInfo signature = 5;
346 optional ImageHeaders image_headers = 6; 351 optional ImageHeaders image_headers = 6;
347 } 352 }
348 353
349 repeated ArchivedBinary archived_binary = 22; 354 repeated ArchivedBinary archived_binary = 22;
350 355
351 // Population that the reporting user is part of. 356 // Population that the reporting user is part of.
352 optional ChromeUserPopulation population = 24; 357 optional ChromeUserPopulation population = 24;
358
359 // True if the .zip or DMG, etc, was 100% successfully unpacked.
360 optional bool archive_valid = 26;
353 } 361 }
354 362
355 message ClientDownloadResponse { 363 message ClientDownloadResponse {
356 enum Verdict { 364 enum Verdict {
357 // Download is considered safe. 365 // Download is considered safe.
358 SAFE = 0; 366 SAFE = 0;
359 // Download is considered dangerous. Chrome should show a warning to the 367 // Download is considered dangerous. Chrome should show a warning to the
360 // user. 368 // user.
361 DANGEROUS = 1; 369 DANGEROUS = 1;
362 // Download is unknown. Chrome should display a less severe warning. 370 // Download is unknown. Chrome should display a less severe warning.
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 // The ASN and country of the client IP. These fields are filled up by 747 // The ASN and country of the client IP. These fields are filled up by
740 // csd_frontend 748 // csd_frontend
741 repeated string client_asn = 6; 749 repeated string client_asn = 6;
742 optional string client_country = 7; 750 optional string client_country = 7;
743 751
744 // Whether user chose to proceed. 752 // Whether user chose to proceed.
745 optional bool did_proceed = 8; 753 optional bool did_proceed = 8;
746 754
747 // Whether user visited this origin before. 755 // Whether user visited this origin before.
748 optional bool repeat_visit = 9; 756 optional bool repeat_visit = 9;
749 } 757 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698