Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1441223002: Disable BITS downloader until stability issues due to crbug.com/475872 (Closed)

Created:
5 years, 1 month ago by Sorin Jianu
Modified:
5 years, 1 month ago
Reviewers:
waffles, Nico
CC:
chromium-reviews, laforge
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BITS downloader until stability issues due to crbug.com/475872 are resolved. https://crrev.com/5081941b99d37952e1c60c9cb24257369d9c6416 has been reverted as a suspect for crbug.com/475872 We will try to reland after the canary has been stabilized, and will try to create a Finch experiment to assess stability of the proposed changelist. R=waffles@chromium.org BUG=552028 Committed: https://crrev.com/bc5f2dcb172d1fae9a791b37248bf880db51289d Cr-Commit-Position: refs/heads/master@{#359476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M components/component_updater/configurator_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Sorin Jianu
5 years, 1 month ago (2015-11-13 00:49:23 UTC) #2
waffles
lgtm
5 years, 1 month ago (2015-11-13 00:50:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441223002/1
5 years, 1 month ago (2015-11-13 00:57:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 02:11:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc5f2dcb172d1fae9a791b37248bf880db51289d Cr-Commit-Position: refs/heads/master@{#359476}
5 years, 1 month ago (2015-11-13 02:12:35 UTC) #7
Nico
please fix: FAILED: ninja -t msvc -e environment.x86 -- "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo /showIncludes /FC @obj\components\component_updater\component_updater.configurator_impl.obj.rsp ...
5 years, 1 month ago (2015-11-13 07:44:14 UTC) #9
Sorin Jianu
5 years, 1 month ago (2015-11-13 17:58:54 UTC) #10
Message was sent while issue was closed.
On 2015/11/13 07:44:14, Nico wrote:
> please fix:
> 
> FAILED: ninja -t msvc -e environment.x86 --
> "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
> /showIncludes /FC
> @obj\components\component_updater\component_updater.configurator_impl.obj.rsp
/c
> ..\..\components\component_updater\configurator_impl.cc
> /Foobj\components\component_updater\component_updater.configurator_impl.obj
> /Fdobj\components\component_updater.cc.pdb 
> ..\..\components\component_updater\configurator_impl.cc(50,12) : error: unused
> variable 'kSwitchDisableBackgroundDownloads' [-Werror,-Wunused-const-variable]
> const char kSwitchDisableBackgroundDownloads[] =
"disable-background-downloads";
>            ^
> 
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/...

will fix.

Powered by Google App Engine
This is Rietveld 408576698