Land Recent QUIC Changes

Land Recent QUIC Changes 

QUIC: step 8, server certificate support.

Merge internal change: 44460951

Returning early from framer callbacks on error.

Merge internal change: 44428665

Rename QUIC_VERSION_NOT_SUPPORTED to QUIC_CRYPTO_VERSION_NOT_SUPPORTED.

Merge internal change: 44422561

QUIC: split the server config into its own file.

This change moves QuicCryptoServerConfig into a separate file so that Chromium
need only link it into tests.

Merge internal change: 44397707

QUIC: remove ifs around error_details

They were never needed and clutter up the code.

Merge internal change: 44275147

QUIC: add tests for 0-RTT handshaking using strike-register.

This change fixes a couple of issues and adds a test that performs a 0-RTT
handshake.

Merge internal change: 44272981

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195897

[Ryan Hamilton, 2013-04-22 22:09:40]

lgtm

[commit-bot: I haz the power, 2013-04-22 22:18:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14411004/4001

[commit-bot: I haz the power, 2013-04-22 22:40:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-23 03:47:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14411004/24001

[commit-bot: I haz the power, 2013-04-23 04:03:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-23 06:08:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14411004/39001

[commit-bot: I haz the power, 2013-04-23 07:27:45]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2013-04-23 13:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14411004/39001

[commit-bot: I haz the power, 2013-04-23 17:50:31]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-23 18:17:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14411004/39001

[ramant (doing other things), 2013-04-23 20:19:03]

Committed patchset #4 manually as r195897 (presubmit successful).

[Nico, 2015-03-08 02:41:39]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-03-08 02:41:40]

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
File net/quic/crypto/source_address_token.cc (right):

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
net/quic/crypto/source_address_token.cc:17:
SourceAddressToken::SourceAddressToken() {
This doesn't set timestamp_. Is that intentional? Creating a SourceAddressToken
and immediately calling timestamp() on it will return uninitialized memory.

[ramant (doing other things), 2015-03-08 23:26:53]

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
File net/quic/crypto/source_address_token.cc (right):

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
net/quic/crypto/source_address_token.cc:17:
SourceAddressToken::SourceAddressToken() {
On 2015/03/08 02:41:40, Nico wrote:
> This doesn't set timestamp_. Is that intentional? Creating a
SourceAddressToken
> and immediately calling timestamp() on it will return uninitialized memory.

Good point. Will upload a change asap.

thanks
raman

[ramant (doing other things), 2015-03-09 00:01:46]

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
File net/quic/crypto/source_address_token.cc (right):

https://codereview.chromium.org/14411004/diff/39001/net/quic/crypto/source_ad...
net/quic/crypto/source_address_token.cc:17:
SourceAddressToken::SourceAddressToken() {
On 2015/03/08 23:26:53, ramant wrote:
> On 2015/03/08 02:41:40, Nico wrote:
> > This doesn't set timestamp_. Is that intentional? Creating a
> SourceAddressToken
> > and immediately calling timestamp() on it will return uninitialized memory.
> 
> Good point. Will upload a change asap.
> 
> thanks
> raman

Uploaded https://codereview.chromium.org/985383003/