Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h

Issue 1441083002: Oilpan: move NavigatorContentUtilsClients to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
diff --git a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
index cb044eccbb7a6e14ba8cc28f4a774130f1e76aa8..f149f70ecdc3e739a00ea37a5e8d91b04e2cf57f 100644
--- a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
+++ b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h
@@ -27,6 +27,7 @@
#define NavigatorContentUtilsClient_h
#include "modules/ModulesExport.h"
+#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "wtf/Allocator.h"
#include "wtf/text/WTFString.h"
@@ -35,8 +36,7 @@ namespace blink {
class LocalFrame;
-class NavigatorContentUtilsClient {
- USING_FAST_MALLOC(NavigatorContentUtilsClient);
haraken 2015/11/13 11:51:38 Nit: USING_FAST_MALLOC_WILL_BE_REMOVED
sof 2015/11/15 07:58:43 Done.
+class NavigatorContentUtilsClient : public NoBaseWillBeGarbageCollectedFinalized<NavigatorContentUtilsClient> {
public:
virtual ~NavigatorContentUtilsClient() { }
virtual void registerProtocolHandler(const String& scheme, const KURL&, const String& title) = 0;
@@ -49,10 +49,12 @@ public:
virtual CustomHandlersState isProtocolHandlerRegistered(const String& scheme, const KURL&) = 0;
virtual void unregisterProtocolHandler(const String& scheme, const KURL&) = 0;
+
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
};
-MODULES_EXPORT void provideNavigatorContentUtilsTo(LocalFrame&, PassOwnPtr<NavigatorContentUtilsClient>);
+MODULES_EXPORT void provideNavigatorContentUtilsTo(LocalFrame&, PassOwnPtrWillBeRawPtr<NavigatorContentUtilsClient>);
-}
+} // namespace blink
#endif // NavigatorContentUtilsClient_h

Powered by Google App Engine
This is Rietveld 408576698