Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1441083002: Oilpan: move NavigatorContentUtilsClients to the heap. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, gyuyoung2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: move NavigatorContentUtilsClients to the heap. Done so as to allow the client implementation keep a Member reference to its WebLocalFrameImpl. R=haraken BUG=553613 Committed: https://crrev.com/f843a13fd4769f5d2462ff9028d2ded705635b97 Cr-Commit-Position: refs/heads/master@{#359775}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add back non-Oilpan USING_FAST_MALLOC() usage for NavigatorContentUtilsClient #

Messages

Total messages: 11 (5 generated)
sof
5 years, 1 month ago (2015-11-12 18:56:37 UTC) #2
haraken
LGTM https://codereview.chromium.org/1441083002/diff/1/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h File third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h (left): https://codereview.chromium.org/1441083002/diff/1/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h#oldcode39 third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h:39: USING_FAST_MALLOC(NavigatorContentUtilsClient); Nit: USING_FAST_MALLOC_WILL_BE_REMOVED
5 years, 1 month ago (2015-11-13 11:51:38 UTC) #4
sof
https://codereview.chromium.org/1441083002/diff/1/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h File third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h (left): https://codereview.chromium.org/1441083002/diff/1/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h#oldcode39 third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h:39: USING_FAST_MALLOC(NavigatorContentUtilsClient); On 2015/11/13 11:51:38, haraken wrote: > > Nit: ...
5 years, 1 month ago (2015-11-15 07:58:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441083002/20001
5 years, 1 month ago (2015-11-15 07:59:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-15 12:16:28 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 12:17:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f843a13fd4769f5d2462ff9028d2ded705635b97
Cr-Commit-Position: refs/heads/master@{#359775}

Powered by Google App Engine
This is Rietveld 408576698