Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

Issue 1441073006: Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed various dchecks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
diff --git a/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc b/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
index 52f4ee85f928ee9bfb9b515b717f2304ae76e805..cb2857b49cface3c32160ba1689b664c8c45653b 100644
--- a/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
+++ b/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
@@ -35,27 +35,32 @@ class MockTaskObserver : public blink::WebThread::TaskObserver {
class WebThreadImplForRendererSchedulerTest : public testing::Test {
public:
- WebThreadImplForRendererSchedulerTest()
- : clock_(new base::SimpleTestTickClock()),
- scheduler_(SchedulerTqmDelegateImpl::Create(
+ WebThreadImplForRendererSchedulerTest() {}
+
+ void SetUp() override {
+ clock_.reset(new base::SimpleTestTickClock());
+ clock_->Advance(base::TimeDelta::FromMicroseconds(5000));
+ scheduler_.reset(new RendererSchedulerImpl(
+ SchedulerTqmDelegateImpl::Create(
&message_loop_,
- make_scoped_ptr(new TestTimeSource(clock_.get())))),
- default_task_runner_(scheduler_.DefaultTaskRunner()),
- thread_(scheduler_.CreateMainThread()) {}
+ make_scoped_ptr(new TestTimeSource(clock_.get())))));
+ default_task_runner_ = scheduler_->DefaultTaskRunner();
+ thread_ = scheduler_->CreateMainThread();
+ }
~WebThreadImplForRendererSchedulerTest() override {}
void SetWorkBatchSizeForTesting(size_t work_batch_size) {
- scheduler_.GetSchedulerHelperForTesting()->SetWorkBatchSizeForTesting(
+ scheduler_->GetSchedulerHelperForTesting()->SetWorkBatchSizeForTesting(
work_batch_size);
}
- void TearDown() override { scheduler_.Shutdown(); }
+ void TearDown() override { scheduler_->Shutdown(); }
protected:
base::MessageLoop message_loop_;
scoped_ptr<base::SimpleTestTickClock> clock_;
- RendererSchedulerImpl scheduler_;
+ scoped_ptr<RendererSchedulerImpl> scheduler_;
scoped_refptr<base::SingleThreadTaskRunner> default_task_runner_;
scoped_ptr<blink::WebThread> thread_;

Powered by Google App Engine
This is Rietveld 408576698