components/scheduler/base/virtual_time_domain.cc - Issue 1441073006: Move throttling of background timers into the renderer scheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/base/virtual_time_domain.cc

Issue 1441073006: Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed various dchecks Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/base/time_domain.cc ('K') | « components/scheduler/base/time_domain.cc ('k') | components/scheduler/child/scheduler_helper.h » ('j') | components/scheduler/renderer/renderer_scheduler_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/base/virtual_time_domain.cc

diff --git a/components/scheduler/base/virtual_time_domain.cc b/components/scheduler/base/virtual_time_domain.cc

index 32510394fda1f744ccc79657b91210757fecb1e4..b3d263239128c7a397025d7ea1a4897d9455192d 100644

--- a/components/scheduler/base/virtual_time_domain.cc

+++ b/components/scheduler/base/virtual_time_domain.cc

@@ -44,6 +44,10 @@ void VirtualTimeDomain::AdvanceTo(base::TimeTicks now) {

base::AutoLock lock(lock_);

DCHECK_GE(now, now_);

now_ = now;

+ DCHECK(task_queue_manager_delegate_);

+ LazyNow lazy_now(now_);

+ WakeupReadyDelayedQueues(&lazy_now);

Sami 2015/11/24 12:48:48 Isn't the DoWork going to do this? Why do it twice

alex clarke (OOO till 29th) 2015/11/25 12:29:36 Seems it isn't needed. It definitely was at one s

task_queue_manager_delegate_->PostTask(FROM_HERE, do_work_closure_);

}