Move throttling of background timers into the renderer scheduler

components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/scheduler/renderer/web_view_scheduler_impl.h"
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "cc/test/ordered_simple_task_runner.h"
 #include "components/scheduler/base/test_time_source.h"
 #include "components/scheduler/child/scheduler_tqm_delegate_for_test.h"
 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
 #include "components/scheduler/renderer/web_frame_scheduler_impl.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebTaskRunner.h"
+#include "third_party/WebKit/public/platform/WebTraceLocation.h"
 
 namespace scheduler {
 
 class WebViewSchedulerImplTest : public testing::Test {
  public:
   WebViewSchedulerImplTest() {}
   ~WebViewSchedulerImplTest() override {}
 
   void SetUp() override {
     clock_.reset(new base::SimpleTestTickClock());
     clock_->Advance(base::TimeDelta::FromMicroseconds(5000));
     mock_task_runner_ = make_scoped_refptr(
         new cc::OrderedSimpleTaskRunner(clock_.get(), false));
     main_task_runner_ = SchedulerTqmDelegateForTest::Create(
         mock_task_runner_, make_scoped_ptr(new TestTimeSource(clock_.get())));
     scheduler_.reset(new RendererSchedulerImpl(main_task_runner_));
     web_view_scheduler_.reset(
-        new WebViewSchedulerImpl(nullptr, scheduler_.get()));
+        new WebViewSchedulerImpl(nullptr, scheduler_.get(), "test.category"));
   }
 
   void TearDown() override { scheduler_->Shutdown(); }
 
   scoped_ptr<base::SimpleTestTickClock> clock_;
   scoped_refptr<cc::OrderedSimpleTaskRunner> mock_task_runner_;
   scoped_refptr<SchedulerTqmDelegate> main_task_runner_;
   scoped_ptr<RendererSchedulerImpl> scheduler_;
   scoped_ptr<WebViewSchedulerImpl> web_view_scheduler_;
 };
 
 TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersBefore) {
   blink::WebPassOwnPtr<blink::WebFrameScheduler> frame1(
       web_view_scheduler_->createFrameScheduler());
   blink::WebPassOwnPtr<blink::WebFrameScheduler> frame2(
       web_view_scheduler_->createFrameScheduler());
 }
 
 TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersAfter) {
   blink::WebPassOwnPtr<blink::WebFrameScheduler> frame1(
       web_view_scheduler_->createFrameScheduler());
   blink::WebPassOwnPtr<blink::WebFrameScheduler> frame2(
       web_view_scheduler_->createFrameScheduler());
   web_view_scheduler_.reset();
 }
 
+TEST_F(WebViewSchedulerImplTest, DelayToNextRunTimeInSeconds) {
+  EXPECT_FLOAT_EQ(
+      1.0, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.0));
+  EXPECT_FLOAT_EQ(
+      0.9, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.1));
+  EXPECT_FLOAT_EQ(
+      0.8, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.2));
+  EXPECT_FLOAT_EQ(
+      0.7, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.3));
+  EXPECT_FLOAT_EQ(
+      0.6, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.4));
+  EXPECT_FLOAT_EQ(
+      0.5, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.5));
+  EXPECT_FLOAT_EQ(
+      0.4, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.6));
+  EXPECT_FLOAT_EQ(
+      0.3, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.7));
+  EXPECT_FLOAT_EQ(
+      0.2, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.8));
+  EXPECT_FLOAT_EQ(
+      1.1, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(0.9));
+  EXPECT_FLOAT_EQ(
+      1.0, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(1.0));
+  EXPECT_FLOAT_EQ(
+      1.0, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(8.0));
+  EXPECT_FLOAT_EQ(
+      0.8, (float)WebViewSchedulerImpl::DelayToNextRunTimeInSeconds(8.2));
+}
+
+namespace {
+class RepeatingTask : public blink::WebTaskRunner::Task {
+ public:
+  RepeatingTask(blink::WebTaskRunner* web_task_runner, int* run_count)
+      : web_task_runner_(web_task_runner), run_count_(run_count) {}
+
+  ~RepeatingTask() override {}
+
+  void run() override {
+    (*run_count_)++;
+    web_task_runner_->postDelayedTask(
+        BLINK_FROM_HERE, new RepeatingTask(web_task_runner_, run_count_), 1.0);
+  }
+
+ private:
+  blink::WebTaskRunner* web_task_runner_;  // NOT OWNED
+  int* run_count_;                         // NOT OWNED
+};
+}  // namespace
+
+TEST_F(WebViewSchedulerImplTest, RepeatingTimer_PageInForeground) {
+  web_view_scheduler_->setPageInBackground(false);
+
+  blink::WebPassOwnPtr<blink::WebFrameScheduler> frame(

[Sami, 2015/11/17 10:12:21]

Looks like this could just be a regular OwnPtr, which would avoid the need to
change WebPassOwnPTr.

[alex clarke (OOO till 29th), 2015/11/23 17:13:46]

As discussed I ended up adding a new method to expose the Impl.

+      web_view_scheduler_->createFrameScheduler());
+
+  int run_count = 0;
+  frame.get()->timerTaskRunner()->postDelayedTask(
+      BLINK_FROM_HERE,
+      new RepeatingTask(frame.get()->timerTaskRunner(), &run_count), 1.0);
+
+  mock_task_runner_->SetAutoAdvanceNowToPendingTasks(true);
+  mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
+  EXPECT_EQ(1000, run_count);
+}
+
+TEST_F(WebViewSchedulerImplTest, RepeatingTimer_PageInBackground) {
+  web_view_scheduler_->setPageInBackground(true);
+
+  blink::WebPassOwnPtr<blink::WebFrameScheduler> frame(
+      web_view_scheduler_->createFrameScheduler());
+
+  int run_count = 0;
+  frame.get()->timerTaskRunner()->postDelayedTask(
+      BLINK_FROM_HERE,
+      new RepeatingTask(frame.get()->timerTaskRunner(), &run_count), 1.0);
+
+  mock_task_runner_->SetAutoAdvanceNowToPendingTasks(true);
+  mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
+  EXPECT_EQ(1, run_count);
+}
+
+TEST_F(WebViewSchedulerImplTest, RepeatingLoadingTask_PageInBackground) {
+  web_view_scheduler_->setPageInBackground(true);
+
+  blink::WebPassOwnPtr<blink::WebFrameScheduler> frame(
+      web_view_scheduler_->createFrameScheduler());
+
+  int run_count = 0;
+  frame.get()->loadingTaskRunner()->postDelayedTask(
+      BLINK_FROM_HERE,
+      new RepeatingTask(frame.get()->loadingTaskRunner(), &run_count), 1.0);
+
+  mock_task_runner_->SetAutoAdvanceNowToPendingTasks(true);
+  mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(1));
+  EXPECT_EQ(1000, run_count);  // Loading tasks should not be throttled
+}
+
 }  // namespace scheduler