Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: components/scheduler/base/time_domain.cc

Issue 1441073006: Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Last few changes Sami requested Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/time_domain.h" 5 #include "components/scheduler/base/time_domain.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "components/scheduler/base/task_queue_impl.h" 9 #include "components/scheduler/base/task_queue_impl.h"
10 #include "components/scheduler/base/task_queue_manager_delegate.h" 10 #include "components/scheduler/base/task_queue_manager_delegate.h"
11 #include "components/scheduler/scheduler_export.h" 11 #include "components/scheduler/scheduler_export.h"
12 12
13 namespace scheduler { 13 namespace scheduler {
14 14
15 TimeDomain::TimeDomain() {} 15 TimeDomain::TimeDomain(Observer* observer) : observer_(observer) {}
16 16
17 TimeDomain::~TimeDomain() {} 17 TimeDomain::~TimeDomain() {
18 for (internal::TaskQueueImpl* queue : registered_task_queues_) {
19 queue->SetTimeDomain(nullptr);
20 }
21 }
22
23 void TimeDomain::RegisterQueue(internal::TaskQueueImpl* queue) {
24 registered_task_queues_.insert(queue);
25 }
18 26
19 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) { 27 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
28 registered_task_queues_.erase(queue);
29
20 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 30 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
21 // little awkward since it's keyed by time. O(n) running time. 31 // little awkward since it's keyed by time. O(n) running time.
22 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin(); 32 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
23 iter != delayed_wakeup_multimap_.end();) { 33 iter != delayed_wakeup_multimap_.end();) {
24 if (iter->second == queue) { 34 if (iter->second == queue) {
25 DelayedWakeupMultimap::iterator temp = iter; 35 DelayedWakeupMultimap::iterator temp = iter;
26 iter++; 36 iter++;
27 // O(1) amortized. 37 // O(1) amortized.
28 delayed_wakeup_multimap_.erase(temp); 38 delayed_wakeup_multimap_.erase(temp);
29 } else { 39 } else {
30 iter++; 40 iter++;
31 } 41 }
32 } 42 }
33 43
34 // |newly_updatable_| might contain |queue|, we use 44 // |newly_updatable_| might contain |queue|, we use
35 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 45 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
36 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 46 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
37 updatable_queue_set_.erase(queue); 47 updatable_queue_set_.erase(queue);
38 } 48 }
39 49
40 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue, 50 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue,
41 TimeDomain* destination_time_domain) { 51 TimeDomain* destination_time_domain) {
52 DCHECK(destination_time_domain);
53 registered_task_queues_.erase(queue);
54
42 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow(); 55 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow();
43 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 56 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
44 // little awkward since it's keyed by time. O(n) running time. 57 // little awkward since it's keyed by time. O(n) running time.
45 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin(); 58 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
46 iter != delayed_wakeup_multimap_.end();) { 59 iter != delayed_wakeup_multimap_.end();) {
47 if (iter->second == queue) { 60 if (iter->second == queue) {
48 destination_time_domain->ScheduleDelayedWork(queue, iter->first, 61 destination_time_domain->ScheduleDelayedWork(queue, iter->first,
49 &destination_lazy_now); 62 &destination_lazy_now);
50 DelayedWakeupMultimap::iterator temp = iter; 63 DelayedWakeupMultimap::iterator temp = iter;
51 iter++; 64 iter++;
52 // O(1) amortized. 65 // O(1) amortized.
53 delayed_wakeup_multimap_.erase(temp); 66 delayed_wakeup_multimap_.erase(temp);
54 } else { 67 } else {
55 iter++; 68 iter++;
56 } 69 }
57 } 70 }
58 71
59 // |newly_updatable_| might contain |queue|, we use 72 // |newly_updatable_| might contain |queue|, we use
60 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 73 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
61 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 74 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
62 updatable_queue_set_.erase(queue); 75 updatable_queue_set_.erase(queue);
76
77 destination_time_domain->RegisterQueue(queue);
63 } 78 }
64 79
65 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue, 80 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
66 base::TimeTicks delayed_run_time, 81 base::TimeTicks delayed_run_time,
67 LazyNow* lazy_now) { 82 LazyNow* lazy_now) {
68 DCHECK(main_thread_checker_.CalledOnValidThread()); 83 DCHECK(main_thread_checker_.CalledOnValidThread());
69 84
70 if (delayed_wakeup_multimap_.empty() || 85 bool delayed_wakeup_multimap_was_empty = delayed_wakeup_multimap_.empty();
86 if (delayed_wakeup_multimap_was_empty ||
71 delayed_run_time < delayed_wakeup_multimap_.begin()->first) { 87 delayed_run_time < delayed_wakeup_multimap_.begin()->first) {
72 base::TimeDelta delay = 88 base::TimeDelta delay =
73 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now()); 89 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
74 RequestWakeup(lazy_now, delay); 90 RequestWakeup(lazy_now, delay);
75 } 91 }
92
93 if (observer_ && delayed_wakeup_multimap_was_empty)
94 observer_->OnTimeDomainHasDelayedWork();
76 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue)); 95 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
77 } 96 }
78 97
79 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) { 98 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) {
80 base::AutoLock lock(newly_updatable_lock_); 99 {
81 newly_updatable_.push_back(queue); 100 base::AutoLock lock(newly_updatable_lock_);
101 newly_updatable_.push_back(queue);
102 }
103 if (observer_)
104 observer_->OnTimeDomainHasImmediateWork();
82 } 105 }
83 106
84 void TimeDomain::UnregisterAsUpdatableTaskQueue( 107 void TimeDomain::UnregisterAsUpdatableTaskQueue(
85 internal::TaskQueueImpl* queue) { 108 internal::TaskQueueImpl* queue) {
86 DCHECK(main_thread_checker_.CalledOnValidThread()); 109 DCHECK(main_thread_checker_.CalledOnValidThread());
87 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 110 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
88 #ifndef NDEBUG 111 #ifndef NDEBUG
89 { 112 {
90 base::AutoLock lock(newly_updatable_lock_); 113 base::AutoLock lock(newly_updatable_lock_);
91 DCHECK(!(updatable_queue_set_.find(queue) == updatable_queue_set_.end() && 114 DCHECK(!(updatable_queue_set_.find(queue) == updatable_queue_set_.end() &&
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 state->SetString("name", GetName()); 192 state->SetString("name", GetName());
170 state->BeginArray("updatable_queue_set"); 193 state->BeginArray("updatable_queue_set");
171 for (auto& queue : updatable_queue_set_) 194 for (auto& queue : updatable_queue_set_)
172 state->AppendString(queue->GetName()); 195 state->AppendString(queue->GetName());
173 state->EndArray(); 196 state->EndArray();
174 AsValueIntoInternal(state); 197 AsValueIntoInternal(state);
175 state->EndDictionary(); 198 state->EndDictionary();
176 } 199 }
177 200
178 } // namespace scheduler 201 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698