Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: src/builtins.cc

Issue 1441043002: [proxies] Implement [[PreventExtensions]] and [[IsExtensible]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Various changes. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/js/v8natives.js » ('j') | src/objects.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins.h" 5 #include "src/builtins.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 1603 matching lines...) Expand 10 before | Expand all | Expand 10 after
1614 DCHECK_EQ(2, args.length()); 1614 DCHECK_EQ(2, args.length());
1615 Handle<Object> target = args.at<Object>(1); 1615 Handle<Object> target = args.at<Object>(1);
1616 1616
1617 if (!target->IsJSReceiver()) { 1617 if (!target->IsJSReceiver()) {
1618 THROW_NEW_ERROR_RETURN_FAILURE( 1618 THROW_NEW_ERROR_RETURN_FAILURE(
1619 isolate, NewTypeError(MessageTemplate::kCalledOnNonObject, 1619 isolate, NewTypeError(MessageTemplate::kCalledOnNonObject,
1620 isolate->factory()->NewStringFromAsciiChecked( 1620 isolate->factory()->NewStringFromAsciiChecked(
1621 "Reflect.isExtensible"))); 1621 "Reflect.isExtensible")));
1622 } 1622 }
1623 1623
1624 // TODO(neis): For now, we ignore proxies. Once proxies are fully 1624 Maybe<bool> result =
1625 // implemented, do something like the following: 1625 JSReceiver::IsExtensible(Handle<JSReceiver>::cast(target));
1626 /* 1626 MAYBE_RETURN(result, isolate->heap()->exception());
1627 Maybe<bool> maybe = JSReceiver::IsExtensible( 1627 return *isolate->factory()->ToBoolean(result.FromJust());
1628 Handle<JSReceiver>::cast(target));
1629 if (!maybe.IsJust()) return isolate->heap()->exception();
1630 return *isolate->factory()->ToBoolean(maybe.FromJust());
1631 */
1632
1633 if (target->IsJSObject()) {
1634 return *isolate->factory()->ToBoolean(
1635 JSObject::IsExtensible(Handle<JSObject>::cast(target)));
1636 }
1637 return *isolate->factory()->false_value();
1638 } 1628 }
1639 1629
1640 1630
1641 // ES6 section 26.1.12 Reflect.preventExtensions 1631 // ES6 section 26.1.12 Reflect.preventExtensions
1642 BUILTIN(ReflectPreventExtensions) { 1632 BUILTIN(ReflectPreventExtensions) {
1643 HandleScope scope(isolate); 1633 HandleScope scope(isolate);
1644 DCHECK_EQ(2, args.length()); 1634 DCHECK_EQ(2, args.length());
1645 Handle<Object> target = args.at<Object>(1); 1635 Handle<Object> target = args.at<Object>(1);
1646 1636
1647 if (!target->IsJSReceiver()) { 1637 if (!target->IsJSReceiver()) {
1648 THROW_NEW_ERROR_RETURN_FAILURE( 1638 THROW_NEW_ERROR_RETURN_FAILURE(
1649 isolate, NewTypeError(MessageTemplate::kCalledOnNonObject, 1639 isolate, NewTypeError(MessageTemplate::kCalledOnNonObject,
1650 isolate->factory()->NewStringFromAsciiChecked( 1640 isolate->factory()->NewStringFromAsciiChecked(
1651 "Reflect.preventExtensions"))); 1641 "Reflect.preventExtensions")));
1652 } 1642 }
1653 1643
1654 Maybe<bool> result = JSReceiver::PreventExtensions( 1644 Maybe<bool> result = JSReceiver::PreventExtensions(
1655 Handle<JSReceiver>::cast(target), Object::DONT_THROW); 1645 Handle<JSReceiver>::cast(target), Object::DONT_THROW);
1656 return result.IsJust() ? *isolate->factory()->ToBoolean(result.FromJust()) 1646 MAYBE_RETURN(result, isolate->heap()->exception());
1657 : isolate->heap()->exception(); 1647 return *isolate->factory()->ToBoolean(result.FromJust());
1658 } 1648 }
1659 1649
1660 1650
1661 // ES6 section 26.1.13 Reflect.set 1651 // ES6 section 26.1.13 Reflect.set
1662 BUILTIN(ReflectSet) { 1652 BUILTIN(ReflectSet) {
1663 HandleScope scope(isolate); 1653 HandleScope scope(isolate);
1664 Handle<Object> undef = isolate->factory()->undefined_value(); 1654 Handle<Object> undef = isolate->factory()->undefined_value();
1665 Handle<Object> target = args.length() > 1 ? args.at<Object>(1) : undef; 1655 Handle<Object> target = args.length() > 1 ? args.at<Object>(1) : undef;
1666 Handle<Object> key = args.length() > 2 ? args.at<Object>(2) : undef; 1656 Handle<Object> key = args.length() > 2 ? args.at<Object>(2) : undef;
1667 Handle<Object> value = args.length() > 3 ? args.at<Object>(3) : undef; 1657 Handle<Object> value = args.length() > 3 ? args.at<Object>(3) : undef;
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
2389 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 2379 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
2390 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 2380 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
2391 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 2381 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
2392 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 2382 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
2393 #undef DEFINE_BUILTIN_ACCESSOR_C 2383 #undef DEFINE_BUILTIN_ACCESSOR_C
2394 #undef DEFINE_BUILTIN_ACCESSOR_A 2384 #undef DEFINE_BUILTIN_ACCESSOR_A
2395 2385
2396 2386
2397 } // namespace internal 2387 } // namespace internal
2398 } // namespace v8 2388 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/js/v8natives.js » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698