Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441033002: Move mojo and mojom from mojo/public/dart to mojo/dart/packages (Closed)

Created:
5 years, 1 month ago by Cutch
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move mojo and mojom from mojo/public/dart to mojo/dart/packages This CL just moves the files and does the necessary changes to get things building and running again. This is likely to break existing developers if they were consuming these packages via mojo/public/dart R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fb583dee3af55949ceeb60008762798f0e51e44d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5274 lines) Patch
M benchmarks/dart_handler_running/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M benchmarks/mojo_rtt_benchmark/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/dart/hello_world/hello/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/dart/hello_world/world/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/dart/netcat/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/dart/traced_application/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 4 chunks +12 lines, -38 lines 0 comments Download
M mojo/dart/http_load_test/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/dart/packages/.gitignore View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/packages/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A mojo/dart/packages/mojo/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A + mojo/dart/packages/mojo/CHANGELOG.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/_sdkext View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/application.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/bindings.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/core.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/application.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/application_connection.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/buffer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/codec.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/control_message.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/data_pipe.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/drain_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/enum.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/event_stream.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/fill_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/handle.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/message.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/message_pipe.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/proxy.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/struct.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/stub.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/types.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/union.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/lib/src/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/sdk_ext/internal.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/sdk_ext/src/natives.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/sdk_ext/src/timer_queue.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojo/sdk_ext/src/wait_many_state.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/dart/packages/mojo/sdk_ext_sources.gni View 1 chunk +14 lines, -0 lines 0 comments Download
A mojo/dart/packages/mojo/sources.gni View 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/dart/packages/mojo_apptest/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/dart/packages/mojom/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/dart/packages/mojom/CHANGELOG.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/bin/mojom.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/command_runner.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/commands/check.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/commands/gen.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/commands/mojom_command.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/commands/single.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/generate.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/mojom_finder.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/lib/src/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/dart/packages/mojom/test/generate_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/dart/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/dart/mojo/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/dart/mojo/CHANGELOG.md View 1 chunk +0 lines, -86 lines 0 comments Download
D mojo/public/dart/mojo/README.md View 1 chunk +0 lines, -128 lines 0 comments Download
D mojo/public/dart/mojo/lib/_sdkext View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/dart/mojo/lib/application.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/public/dart/mojo/lib/bindings.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/dart/mojo/lib/core.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/application.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/application_connection.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/buffer.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/codec.dart View 1 chunk +0 lines, -908 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/control_message.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/data_pipe.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/drain_data.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/enum.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/event_stream.dart View 1 chunk +0 lines, -234 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/fill_data.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/handle.dart View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/message.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/message_pipe.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/proxy.dart View 1 chunk +0 lines, -248 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/struct.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/stub.dart View 1 chunk +0 lines, -134 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/types.dart View 1 chunk +0 lines, -260 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/union.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/dart/mojo/lib/src/utils.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/public/dart/mojo/pubspec.yaml View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/public/dart/mojo/sdk_ext/internal.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/public/dart/mojo/sdk_ext/src/handle_watcher.dart View 1 chunk +0 lines, -336 lines 0 comments Download
D mojo/public/dart/mojo/sdk_ext/src/natives.dart View 1 chunk +0 lines, -157 lines 0 comments Download
D mojo/public/dart/mojo/sdk_ext/src/timer_queue.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/dart/mojo/sdk_ext/src/wait_many_state.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D mojo/public/dart/mojom/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/public/dart/mojom/CHANGELOG.md View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/public/dart/mojom/README.md View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/public/dart/mojom/bin/mojom.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/dart/mojom/lib/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/command_runner.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/commands/check.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/commands/gen.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/commands/mojom_command.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/commands/single.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/generate.dart View 1 chunk +0 lines, -414 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/mojom_finder.dart View 1 chunk +0 lines, -120 lines 0 comments Download
D mojo/public/dart/mojom/lib/src/utils.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D mojo/public/dart/mojom/pubspec.yaml View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/public/dart/mojom/test/generate_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/public/dart/sdk_ext_sources.gni View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/dart_apptests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/dart/test/echo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/dart/test/pingpong/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/dart/test/pingpong_target/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
5 years, 1 month ago (2015-11-12 17:07:49 UTC) #4
jamesr
lgtm
5 years, 1 month ago (2015-11-12 17:37:59 UTC) #5
Cutch
5 years, 1 month ago (2015-11-12 17:39:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fb583dee3af55949ceeb60008762798f0e51e44d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698