Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1441013003: Issue 24812. Fix for detached CompilationUnitElement(s) after package version switch. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24812. Fix for detached CompilationUnitElement(s) after package version switch. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24812 Committed: https://github.com/dart-lang/sdk/commit/a21e3a5a7f954649434c1edfa6cba5c0e99f8bc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -20 lines) Patch
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 6 chunks +81 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 6 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-12 21:05:32 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-12 21:13:23 UTC) #2
scheglov
5 years, 1 month ago (2015-11-12 21:22:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a21e3a5a7f954649434c1edfa6cba5c0e99f8bc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698