Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1440983002: Serializer: attach alignment to deferred objects. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: attach alignment to deferred objects. R=jkummerow@chromium.org BUG=chromium:523919 LOG=N Committed: https://crrev.com/ee9020ddd90900ecb29abc4f5e9e78151f630906 Cr-Commit-Position: refs/heads/master@{#31956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -17 lines) Patch
M src/snapshot/serialize.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 3 chunks +24 lines, -17 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-523919.js View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440983002/1
5 years, 1 month ago (2015-11-12 09:41:02 UTC) #2
Jakob Kummerow
LGTM. Consider backmerging this fix at least to 4.8 (if it doesn't make the branch ...
5 years, 1 month ago (2015-11-12 09:46:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 09:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440983002/1
5 years, 1 month ago (2015-11-12 11:27:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 11:28:25 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee9020ddd90900ecb29abc4f5e9e78151f630906
Cr-Commit-Position: refs/heads/master@{#31956}

Powered by Google App Engine
This is Rietveld 408576698