Add --out-dir command line option to test_runner.py.

build/android/pylib/constants.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Defines a set of constants shared by test runners and other scripts."""
 
 import collections
 import logging
 import os
 import subprocess
@@ skipping 131 matching lines @@
   try:
     return os.environ['BUILDTYPE']
   except KeyError:
     raise Exception('The BUILDTYPE environment variable has not been set')
 
 
 def SetBuildType(build_type):
   os.environ['BUILDTYPE'] = build_type
 
 
 def GetOutDirectory(build_type=None):

[frankf, 2014/01/23 00:54:36]

Craig changed this recently.

It doesn't make sense to me why we need to use env variables at all here
(BUILDTYPE or CHROMIUM_OUT_DIR). It's pythonic to just provide command line
flags with default values.

@Craig, do you agree?

[jbudorick, 2014/01/24 17:52:51]

Would our goal be to have the out directory & build type passed around with the
rest of the options, or would we leave these globals and just not use the
environment variables?

I was working on the former option yesterday afternoon, and it turned out to be
considerably less trivial than I initially thought.

   """Returns the out directory where the output binaries are built.
 
   Args:
     build_type: Build type, generally 'Debug' or 'Release'. Defaults to the
       globally set build type environment variable BUILDTYPE.
   """
   return os.path.abspath(os.path.join(
       DIR_SOURCE_ROOT, os.environ.get('CHROMIUM_OUT_DIR', 'out'),
       GetBuildType() if build_type is None else build_type))
 
 
+def SetOutDirectory(out_directory):
+  os.environ['CHROMIUM_OUT_DIR'] = out_directory
+
+
 def _Memoize(func):
   def Wrapper():
     try:
       return func._result
     except AttributeError:
       func._result = func()
       return func._result
   return Wrapper
 
 
 @_Memoize
 def GetAdbPath():
   if os.environ.get('ANDROID_SDK_ROOT'):
     return 'adb'
   # If envsetup.sh hasn't been sourced and there's no adb in the path,
   # set it here.
   try:
     with file(os.devnull, 'w') as devnull:
       subprocess.call(['adb', 'version'], stdout=devnull, stderr=devnull)
     return 'adb'
   except OSError:
     logging.debug('No adb found in $PATH, fallback to checked in binary.')
     return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb')
 
 
 # Exit codes
 ERROR_EXIT_CODE = 1
 WARNING_EXIT_CODE = 88