Add --out-dir command line option to test_runner.py.

Add --out-dir command line option to test_runner.py.

BUG=294427
NOTRY=True

closed: superseded by https://codereview.chromium.org/639853002/

[jbudorick, 2014-01-22 00:47:04]

If --test-apk is passed a path to an actual apk file, test_runner will now
attempt to use it and find the corresponding jar file rather than looking for
ChromeTest.apk.jar.

[frankf, 2014-01-22 18:48:43]

Hmm. So the problem in the bug is that there are potentially multiple 'out'
directories. The general solution is for test scripts to know what the current
out directory is (using that env variable or adding command line flag). There
are other build artifacts dependencies besides the test apk.

[jbudorick, 2014-01-23 00:09:54]

On 2014/01/22 18:48:43, frankf wrote:
> Hmm. So the problem in the bug is that there are potentially multiple 'out'
> directories. The general solution is for test scripts to know what the current
> out directory is (using that env variable or adding command line flag). There
> are other build artifacts dependencies besides the test apk.

Yeah, I misread this one. I'm working on adding the command line flag.

[frankf, 2014-01-23 00:54:35]

https://codereview.chromium.org/144093008/diff/60001/build/android/pylib/cons...
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/144093008/diff/60001/build/android/pylib/cons...
build/android/pylib/constants.py:152: def GetOutDirectory(build_type=None):
Craig changed this recently.

It doesn't make sense to me why we need to use env variables at all here
(BUILDTYPE or CHROMIUM_OUT_DIR). It's pythonic to just provide command line
flags with default values.

@Craig, do you agree?

https://codereview.chromium.org/144093008/diff/60001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/144093008/diff/60001/build/android/test_runne...
build/android/test_runner.py:87: group.add_option('--out-dir',
dest='out_directory',
let's move this up to after --release option above

[jbudorick, 2014-01-24 17:52:50]

https://codereview.chromium.org/144093008/diff/60001/build/android/pylib/cons...
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/144093008/diff/60001/build/android/pylib/cons...
build/android/pylib/constants.py:152: def GetOutDirectory(build_type=None):
On 2014/01/23 00:54:36, frankf wrote:
> Craig changed this recently.
> 
> It doesn't make sense to me why we need to use env variables at all here
> (BUILDTYPE or CHROMIUM_OUT_DIR). It's pythonic to just provide command line
> flags with default values.
> 
> @Craig, do you agree?

Would our goal be to have the out directory & build type passed around with the
rest of the options, or would we leave these globals and just not use the
environment variables?

I was working on the former option yesterday afternoon, and it turned out to be
considerably less trivial than I initially thought.

[frankf, 2014-01-24 18:39:04]

cc'ing some people who might have an opinion on this:

- iancottrell who's working on cr too
- thakis who's working on getting rid of Android env vars

It makes sense to me to pass the full out directory similar to cr tool:

--out=out_android/Release

and get rid of setting/getting those env vars. Obviously you still keep as
singletons in python.

[Nico, 2014-01-24 18:50:58]

Can't you infer the out dir from the --test-apk=out/Debug/apks/ChromeTest.apk
parameter?

+1 on not using env vars more.

[frankf, 2014-01-24 18:57:32]

On 2014/01/24 18:50:58, Nico wrote:
> Can't you infer the out dir from the --test-apk=out/Debug/apks/ChromeTest.apk
> parameter?
> 
> +1 on not using env vars more.

There are different types of tests on Android, not all test --test-apk
There should be a common option.

[ian_cottrell, 2014-01-24 20:06:54]

On 2014/01/24 18:57:32, frankf wrote:
> On 2014/01/24 18:50:58, Nico wrote:
> > Can't you infer the out dir from the
--test-apk=out/Debug/apks/ChromeTest.apk
> > parameter?
> > 
> > +1 on not using env vars more.
> 
> There are different types of tests on Android, not all test --test-apk
> There should be a common option.

+1 on killing all use of env vars

if you specify the out dir, you could (optionally) remove the need to specify it
again in the apk part

  --out=out/Debug --test-apk=ChromeTest

in theory is sufficient?

[jbudorick, 2014-01-24 20:12:40]

On 2014/01/24 20:06:54, ian_cottrell wrote:
> On 2014/01/24 18:57:32, frankf wrote:
> > On 2014/01/24 18:50:58, Nico wrote:
> > > Can't you infer the out dir from the
> --test-apk=out/Debug/apks/ChromeTest.apk
> > > parameter?
> > > 
> > > +1 on not using env vars more.
> > 
> > There are different types of tests on Android, not all test --test-apk
> > There should be a common option.
> 
> +1 on killing all use of env vars
> 
> if you specify the out dir, you could (optionally) remove the need to specify
it
> again in the apk part
> 
>   --out=out/Debug --test-apk=ChromeTest
> 
> in theory is sufficient?

The first patch in this review partially did what you two have suggested here.
I'm not sure if it's a great idea to implicitly grab the value of one parameter
from another.

Also, at the moment, I don't think the script even works correctly if you _do_
specify the out dir in the apk part. (Obviously, that can be changed.)