Issue 14408006: Properly consider Double inputs for representation inference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14408006: Properly consider Double inputs for representation inference (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow

Modified:
7 years, 8 months ago

Reviewers:
danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly consider Double inputs for representation inference when they are not marked as kFlexibleRepresentation Committed: http://code.google.com/p/v8/source/detail?r=14413

Patch Set 1 #

Patch Set 2 : fixed nit #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/hydrogen-instructions.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Committed patchset #2 manually as r14413 (presubmit successful).

7 years, 8 months ago (2013-04-24 12:39:37 UTC) #4

Yang

7 years, 8 months ago (2013-04-24 15:34:58 UTC) #5

Message was sent while issue was closed.

On 2013/04/24 12:39:37, Jakob wrote:
> Committed patchset #2 manually as r14413 (presubmit successful).

This Patch breaks no-snapshot build. Test case:

out/ia32.release/d8 --test --stress-opt --always-opt --nobreak-on-abort
--nodead-code-elimination --nofold-constants test/mjsunit/mjsunit.js
test/mjsunit/regress/regress-927.js --trace-opt

Expand Messages | Collapse Messages