Source/core/css/MediaQueryMatcher.cpp - Issue 14408004: Fix incorrect evaluation of resolution media queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 14408004: Fix incorrect evaluation of resolution media queries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaQueryMatcher.cpp

diff --git a/Source/core/css/MediaQueryMatcher.cpp b/Source/core/css/MediaQueryMatcher.cpp

index 4ced467ac5bdd4bc07d8fbf4b706254f44a54595..b93fcc59bd2e177d72199d5e0caccb06177e49f0 100644

--- a/Source/core/css/MediaQueryMatcher.cpp

+++ b/Source/core/css/MediaQueryMatcher.cpp

@@ -108,10 +108,8 @@ PassRefPtr<MediaQueryList> MediaQueryMatcher::matchMedia(const String& query)

return 0;

RefPtr<MediaQuerySet> media = MediaQuerySet::create(query);

-#if ENABLE(RESOLUTION_MEDIA_QUERY)

// Add warning message to inspector whenever dpi/dpcm values are used for "screen" media.

reportMediaQueryWarningIfNeeded(m_document, media.get());

-#endif

return MediaQueryList::create(this, media, evaluate(media.get()));

}

« no previous file with comments | « Source/core/css/MediaQueryExp.cpp ('k') | Source/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »