Source/core/css/CSSPrimitiveValue.h - Issue 14408004: Fix incorrect evaluation of resolution media queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 14408004: Fix incorrect evaluation of resolution media queries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/media/mq-resolution-expected.txt ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | Source/core/css/MediaQueryEvaluator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSPrimitiveValue.h

diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h

index b230400af3fccbd1db9fded4ace9086baa1ba58a..e02341a5f4336619326c81404d989a42d8660f42 100644

--- a/Source/core/css/CSSPrimitiveValue.h

+++ b/Source/core/css/CSSPrimitiveValue.h

@@ -182,6 +182,11 @@ public:

bool isDotsPerInch() const { return primitiveType() == CSS_DPI; }

bool isDotsPerPixel() const { return primitiveType() == CSS_DPPX; }

bool isDotsPerCentimeter() const { return primitiveType() == CSS_DPCM; }

+ bool isResolution() const

+ {

+ unsigned short type = primitiveType();

+ return type >= CSS_DPPX && type <= CSS_DPCM;

+ }

bool isVariableName() const { return primitiveType() == CSS_VARIABLE_NAME; }

bool isViewportPercentageLength() const { return m_primitiveUnitType >= CSS_VW && m_primitiveUnitType <= CSS_VMAX; }

« no previous file with comments | « LayoutTests/fast/media/mq-resolution-expected.txt ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | Source/core/css/MediaQueryEvaluator.cpp » ('J')