Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: Source/core/testing/InternalSettings.cpp

Issue 14408004: Fix incorrect evaluation of resolution media queries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 : m_originalCSSExclusionsEnabled(RuntimeEnabledFeatures::cssExclusionsEnable d()) 69 : m_originalCSSExclusionsEnabled(RuntimeEnabledFeatures::cssExclusionsEnable d())
70 , m_originalCSSVariablesEnabled(settings->cssVariablesEnabled()) 70 , m_originalCSSVariablesEnabled(settings->cssVariablesEnabled())
71 , m_originalShadowDOMEnabled(RuntimeEnabledFeatures::shadowDOMEnabled()) 71 , m_originalShadowDOMEnabled(RuntimeEnabledFeatures::shadowDOMEnabled())
72 , m_originalAuthorShadowDOMForAnyElementEnabled(RuntimeEnabledFeatures::auth orShadowDOMForAnyElementEnabled()) 72 , m_originalAuthorShadowDOMForAnyElementEnabled(RuntimeEnabledFeatures::auth orShadowDOMForAnyElementEnabled())
73 , m_originalExperimentalShadowDOMEnabled(RuntimeEnabledFeatures::experimenta lShadowDOMEnabled()) 73 , m_originalExperimentalShadowDOMEnabled(RuntimeEnabledFeatures::experimenta lShadowDOMEnabled())
74 , m_originalStyleScoped(RuntimeEnabledFeatures::styleScopedEnabled()) 74 , m_originalStyleScoped(RuntimeEnabledFeatures::styleScopedEnabled())
75 , m_originalEditingBehavior(settings->editingBehaviorType()) 75 , m_originalEditingBehavior(settings->editingBehaviorType())
76 , m_originalTextAutosizingEnabled(settings->textAutosizingEnabled()) 76 , m_originalTextAutosizingEnabled(settings->textAutosizingEnabled())
77 , m_originalTextAutosizingWindowSizeOverride(settings->textAutosizingWindowS izeOverride()) 77 , m_originalTextAutosizingWindowSizeOverride(settings->textAutosizingWindowS izeOverride())
78 , m_originalTextAutosizingFontScaleFactor(settings->textAutosizingFontScaleF actor()) 78 , m_originalTextAutosizingFontScaleFactor(settings->textAutosizingFontScaleF actor())
79 , m_originalResolutionOverride(settings->resolutionOverride())
80 , m_originalMediaTypeOverride(settings->mediaTypeOverride()) 79 , m_originalMediaTypeOverride(settings->mediaTypeOverride())
81 #if ENABLE(DIALOG_ELEMENT) 80 #if ENABLE(DIALOG_ELEMENT)
82 , m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnable d()) 81 , m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnable d())
83 #endif 82 #endif
84 , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled()) 83 , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
85 , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttri buteAwareFormControlUIEnabled()) 84 , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttri buteAwareFormControlUIEnabled())
86 , m_imagesEnabled(settings->areImagesEnabled()) 85 , m_imagesEnabled(settings->areImagesEnabled())
87 , m_minimumTimerInterval(settings->minDOMTimerInterval()) 86 , m_minimumTimerInterval(settings->minDOMTimerInterval())
88 , m_shouldDisplaySubtitles(settings->shouldDisplaySubtitles()) 87 , m_shouldDisplaySubtitles(settings->shouldDisplaySubtitles())
89 , m_shouldDisplayCaptions(settings->shouldDisplayCaptions()) 88 , m_shouldDisplayCaptions(settings->shouldDisplayCaptions())
90 , m_shouldDisplayTextDescriptions(settings->shouldDisplayTextDescriptions()) 89 , m_shouldDisplayTextDescriptions(settings->shouldDisplayTextDescriptions())
91 , m_defaultVideoPosterURL(settings->defaultVideoPosterURL()) 90 , m_defaultVideoPosterURL(settings->defaultVideoPosterURL())
92 { 91 {
93 } 92 }
94 93
95 void InternalSettings::Backup::restoreTo(Settings* settings) 94 void InternalSettings::Backup::restoreTo(Settings* settings)
96 { 95 {
97 RuntimeEnabledFeatures::setCSSExclusionsEnabled(m_originalCSSExclusionsEnabl ed); 96 RuntimeEnabledFeatures::setCSSExclusionsEnabled(m_originalCSSExclusionsEnabl ed);
98 settings->setCSSVariablesEnabled(m_originalCSSVariablesEnabled); 97 settings->setCSSVariablesEnabled(m_originalCSSVariablesEnabled);
99 RuntimeEnabledFeatures::setShadowDOMEnabled(m_originalShadowDOMEnabled); 98 RuntimeEnabledFeatures::setShadowDOMEnabled(m_originalShadowDOMEnabled);
100 RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled(m_originalAut horShadowDOMForAnyElementEnabled); 99 RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled(m_originalAut horShadowDOMForAnyElementEnabled);
101 RuntimeEnabledFeatures::setExperimentalShadowDOMEnabled(m_originalExperiment alShadowDOMEnabled); 100 RuntimeEnabledFeatures::setExperimentalShadowDOMEnabled(m_originalExperiment alShadowDOMEnabled);
102 RuntimeEnabledFeatures::setStyleScopedEnabled(m_originalStyleScoped); 101 RuntimeEnabledFeatures::setStyleScopedEnabled(m_originalStyleScoped);
103 settings->setEditingBehaviorType(m_originalEditingBehavior); 102 settings->setEditingBehaviorType(m_originalEditingBehavior);
104 settings->setTextAutosizingEnabled(m_originalTextAutosizingEnabled); 103 settings->setTextAutosizingEnabled(m_originalTextAutosizingEnabled);
105 settings->setTextAutosizingWindowSizeOverride(m_originalTextAutosizingWindow SizeOverride); 104 settings->setTextAutosizingWindowSizeOverride(m_originalTextAutosizingWindow SizeOverride);
106 settings->setTextAutosizingFontScaleFactor(m_originalTextAutosizingFontScale Factor); 105 settings->setTextAutosizingFontScaleFactor(m_originalTextAutosizingFontScale Factor);
107 settings->setResolutionOverride(m_originalResolutionOverride);
108 settings->setMediaTypeOverride(m_originalMediaTypeOverride); 106 settings->setMediaTypeOverride(m_originalMediaTypeOverride);
109 #if ENABLE(DIALOG_ELEMENT) 107 #if ENABLE(DIALOG_ELEMENT)
110 RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabl ed); 108 RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabl ed);
111 #endif 109 #endif
112 settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled); 110 settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
113 RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttr ibuteAwareFormControlUIEnabled); 111 RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttr ibuteAwareFormControlUIEnabled);
114 settings->setImagesEnabled(m_imagesEnabled); 112 settings->setImagesEnabled(m_imagesEnabled);
115 settings->setMinDOMTimerInterval(m_minimumTimerInterval); 113 settings->setMinDOMTimerInterval(m_minimumTimerInterval);
116 settings->setShouldDisplaySubtitles(m_shouldDisplaySubtitles); 114 settings->setShouldDisplaySubtitles(m_shouldDisplaySubtitles);
117 settings->setShouldDisplayCaptions(m_shouldDisplayCaptions); 115 settings->setShouldDisplayCaptions(m_shouldDisplayCaptions);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 152
155 InternalSettings::InternalSettings(Page* page) 153 InternalSettings::InternalSettings(Page* page)
156 : InternalSettingsGenerated(page) 154 : InternalSettingsGenerated(page)
157 , m_page(page) 155 , m_page(page)
158 , m_backup(page->settings()) 156 , m_backup(page->settings())
159 { 157 {
160 } 158 }
161 159
162 void InternalSettings::resetToConsistentState() 160 void InternalSettings::resetToConsistentState()
163 { 161 {
162 page()->setDeviceScaleFactor(1);
164 page()->setPageScaleFactor(1, IntPoint(0, 0)); 163 page()->setPageScaleFactor(1, IntPoint(0, 0));
165 page()->setCanStartMedia(true); 164 page()->setCanStartMedia(true);
166 165
167 m_backup.restoreTo(settings()); 166 m_backup.restoreTo(settings());
168 m_backup = Backup(settings()); 167 m_backup = Backup(settings());
169 168
170 InternalSettingsGenerated::resetToConsistentState(); 169 InternalSettingsGenerated::resetToConsistentState();
171 } 170 }
172 171
173 Settings* InternalSettings::settings() const 172 Settings* InternalSettings::settings() const
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 InternalSettingsGuardForSettings(); 276 InternalSettingsGuardForSettings();
278 settings()->setTextAutosizingEnabled(enabled); 277 settings()->setTextAutosizingEnabled(enabled);
279 } 278 }
280 279
281 void InternalSettings::setTextAutosizingWindowSizeOverride(int width, int height , ExceptionCode& ec) 280 void InternalSettings::setTextAutosizingWindowSizeOverride(int width, int height , ExceptionCode& ec)
282 { 281 {
283 InternalSettingsGuardForSettings(); 282 InternalSettingsGuardForSettings();
284 settings()->setTextAutosizingWindowSizeOverride(IntSize(width, height)); 283 settings()->setTextAutosizingWindowSizeOverride(IntSize(width, height));
285 } 284 }
286 285
287 void InternalSettings::setResolutionOverride(int dotsPerCSSInchHorizontally, int dotsPerCSSInchVertically, ExceptionCode& ec)
288 {
289 InternalSettingsGuardForSettings();
290 // An empty size resets the override.
291 settings()->setResolutionOverride(IntSize(dotsPerCSSInchHorizontally, dotsPe rCSSInchVertically));
292 }
293
294 void InternalSettings::setMediaTypeOverride(const String& mediaType, ExceptionCo de& ec) 286 void InternalSettings::setMediaTypeOverride(const String& mediaType, ExceptionCo de& ec)
295 { 287 {
296 InternalSettingsGuardForSettings(); 288 InternalSettingsGuardForSettings();
297 settings()->setMediaTypeOverride(mediaType); 289 settings()->setMediaTypeOverride(mediaType);
298 } 290 }
299 291
300 void InternalSettings::setTextAutosizingFontScaleFactor(float fontScaleFactor, E xceptionCode& ec) 292 void InternalSettings::setTextAutosizingFontScaleFactor(float fontScaleFactor, E xceptionCode& ec)
301 { 293 {
302 InternalSettingsGuardForSettings(); 294 InternalSettingsGuardForSettings();
303 settings()->setTextAutosizingFontScaleFactor(fontScaleFactor); 295 settings()->setTextAutosizingFontScaleFactor(fontScaleFactor);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 settings()->setMinDOMTimerInterval(intervalInSeconds); 398 settings()->setMinDOMTimerInterval(intervalInSeconds);
407 } 399 }
408 400
409 void InternalSettings::setDefaultVideoPosterURL(const String& url, ExceptionCode & ec) 401 void InternalSettings::setDefaultVideoPosterURL(const String& url, ExceptionCode & ec)
410 { 402 {
411 InternalSettingsGuardForSettings(); 403 InternalSettingsGuardForSettings();
412 settings()->setDefaultVideoPosterURL(url); 404 settings()->setDefaultVideoPosterURL(url);
413 } 405 }
414 406
415 } 407 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698