Include field reference with implicit getter / setter functions

Include field reference with implicit getter / setter functions

- When printing implicit getter or setter functions, include the field that the implicit functions were generated for.
- Display field on function view in Observatory.
- Service unit test.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/c6a8c44eae1b256be991033cdb275c63e88afddc

[Cutch, 2015-11-11 20:35:54]

Description was changed from

==========
Include field reference with implicit getter / setter functions

BUG=
==========

to

==========
Include field reference with implicit getter / setter functions

BUG=
==========

[Cutch, 2015-11-11 20:35:54]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2015-11-11 20:36:38]

Description was changed from

==========
Include field reference with implicit getter / setter functions

BUG=
==========

to

==========
Include field reference with implicit getter / setter functions

- When printing implicit getter or setter functions, include the field that the
implicit functions were generated for.
- Display field on function view in Observatory.
- Service unit test.
==========

[rmacnak, 2015-11-11 20:43:02]

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc...
runtime/vm/object.cc:5557: printf("Looking for %" Pd " == %" Pd "\n",
field.token_pos(), token_pos());
Stray print

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc...
runtime/vm/object.cc:7324: (kind() == RawFunction::kImplicitSetter)) {
and kImplicitStaticFinalGetter

[Cutch, 2015-11-11 20:54:22]

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc...
runtime/vm/object.cc:5557: printf("Looking for %" Pd " == %" Pd "\n",
field.token_pos(), token_pos());
On 2015/11/11 20:43:02, rmacnak wrote:
> Stray print

Done.

https://chromiumcodereview.appspot.com/1440753002/diff/1/runtime/vm/object.cc...
runtime/vm/object.cc:7324: (kind() == RawFunction::kImplicitSetter)) {
On 2015/11/11 20:43:02, rmacnak wrote:
> and kImplicitStaticFinalGetter

Done.

[rmacnak, 2015-11-11 21:30:58]

lgtm

[Cutch, 2015-11-11 22:13:49]

Committed patchset #2 (id:20001) manually as
c6a8c44eae1b256be991033cdb275c63e88afddc (presubmit successful).