Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1440723002: Fix test-heap/LargeObjectSlotRecording. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test-heap/LargeObjectSlotRecording. Remove hard-coded assumption of large object size threshold. This test fails on PPC in version 4.7 where the threshold is derived directly from the allocator's pagesize. R=hpayer@chromium.org, mstarzinger@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/59a0641820c8599ec6a6650d7dea1e1424586628 Cr-Commit-Position: refs/heads/master@{#31963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-11 19:10:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440723002/1
5 years, 1 month ago (2015-11-11 20:22:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-11 20:22:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440723002/1
5 years, 1 month ago (2015-11-11 20:26:21 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 21:04:22 UTC) #9
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-12 09:13:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440723002/1
5 years, 1 month ago (2015-11-12 14:31:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 14:33:05 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59a0641820c8599ec6a6650d7dea1e1424586628
Cr-Commit-Position: refs/heads/master@{#31963}

Powered by Google App Engine
This is Rietveld 408576698