Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tests/PathOpsExtendedTest.cpp

Issue 14407006: path ops -- handle non-finite numbers (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/PathOpsExtendedTest.cpp
===================================================================
--- tests/PathOpsExtendedTest.cpp (revision 8862)
+++ tests/PathOpsExtendedTest.cpp (working copy)
@@ -449,7 +449,11 @@
if (gShowPath) {
showPath(path);
}
- Simplify(path, &out);
+ if (!Simplify(path, &out)) {
+ SkDebugf("%s did not expect failure\n", __FUNCTION__);
+ REPORTER_ASSERT(state.fReporter, 0);
+ return false;
+ }
if (!gComparePaths) {
return true;
}
@@ -478,7 +482,11 @@
showPathData(path);
#endif
SkPath out;
- Simplify(path, &out);
+ if (!Simplify(path, &out)) {
+ SkDebugf("%s did not expect failure\n", __FUNCTION__);
+ REPORTER_ASSERT(reporter, 0);
+ return false;
+ }
SkBitmap bitmap;
int result = comparePaths(reporter, path, out, bitmap);
if (result && gPathStrAssert) {
@@ -496,7 +504,11 @@
showPathData(b);
#endif
SkPath out;
- Op(a, b, shapeOp, &out);
+ if (!Op(a, b, shapeOp, &out) ) {
+ SkDebugf("%s did not expect failure\n", __FUNCTION__);
+ REPORTER_ASSERT(reporter, 0);
+ return false;
+ }
SkPath pathOut, scaledPathOut;
SkRegion rgnA, rgnB, openClip, rgnOut;
openClip.setRect(-16000, -16000, 16000, 16000);

Powered by Google App Engine
This is Rietveld 408576698