Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 14407006: path ops -- handle non-finite numbers (Closed)

Created:
7 years, 7 months ago by caryclark
Modified:
7 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

path ops -- handle non-finite numbers Op() and Simplify() do nothing if the input is non-finite. Add code and tests. Committed: https://code.google.com/p/skia/source/detail?r=8882

Patch Set 1 #

Total comments: 2

Patch Set 2 : path ops -- handle non-finite numbers #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M src/pathops/SkPathOpsOp.cpp View 1 2 4 chunks +16 lines, -6 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
No reviewers yet.
7 years, 7 months ago (2013-04-26 16:39:08 UTC) #1
caryclark
7 years, 7 months ago (2013-04-26 16:42:59 UTC) #2
reed1
https://codereview.chromium.org/14407006/diff/1/src/pathops/SkOpEdgeBuilder.cpp File src/pathops/SkOpEdgeBuilder.cpp (right): https://codereview.chromium.org/14407006/diff/1/src/pathops/SkOpEdgeBuilder.cpp#newcode167 src/pathops/SkOpEdgeBuilder.cpp:167: if (!is_finite_point(pointsPtr[0])) { Would it be faster to just ...
7 years, 7 months ago (2013-04-26 17:49:14 UTC) #3
caryclark
path ops -- handle non-finite numbers Op() and Simplify() do nothing if the input is ...
7 years, 7 months ago (2013-04-26 19:44:58 UTC) #4
caryclark
https://codereview.chromium.org/14407006/diff/1/src/pathops/SkOpEdgeBuilder.cpp File src/pathops/SkOpEdgeBuilder.cpp (right): https://codereview.chromium.org/14407006/diff/1/src/pathops/SkOpEdgeBuilder.cpp#newcode167 src/pathops/SkOpEdgeBuilder.cpp:167: if (!is_finite_point(pointsPtr[0])) { Yes indeed. Done and uploaded. On ...
7 years, 7 months ago (2013-04-26 19:47:30 UTC) #5
reed1
lgtm
7 years, 7 months ago (2013-04-26 19:49:52 UTC) #6
caryclark
7 years, 7 months ago (2013-04-26 19:51:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r8882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698