Issue 1440693004: Guard against null pointer exception in status page generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1440693004: Guard against null pointer exception in status page generation (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson

Modified:
5 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Guard against null pointer exception in status page generation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e1c39602ba1ef866934f35d3d8a0ab7f8efa38e5

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/status/get_handler.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/1440693004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1440693004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode381 pkg/analysis_server/lib/src/status/get_handler.dart:381: if (entry != null && entry.exception != null) ...

5 years, 1 month ago (2015-11-11 22:46:12 UTC) #3

Brian Wilkerson

5 years, 1 month ago (2015-11-11 22:55:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e1c39602ba1ef866934f35d3d8a0ab7f8efa38e5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages