Handle another form of MOVW in ARM integrated assembler.

Handle another form of MOVW in ARM integrated assembler.

Extends assembler movw method to handle integer constants in addition
to relocatable constants, since (32-bit) integer constants are
frequently used in movw instructions.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5ff0cfb442b666fe435291c25cccae5eacd90ac6

[Karl, 2015-11-11 17:16:09]

Description was changed from

==========
Handle another form of MOVW in ARM integrated assembler.

Extends assembler movw method to handle integer constants in addition
to relocatable constants, since (32-bit) integer constants are
frequently used in movw instructions.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Handle another form of MOVW in ARM integrated assembler.

Extends assembler movw method to handle integer constants in addition
to relocatable constants, since (32-bit) integer constants are
frequently used in movw instructions.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-11-11 17:16:09]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-11-11 21:46:39]

lgtm

https://codereview.chromium.org/1440693002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1440693002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:796: // to handle cases where the constant is greater
tham 16 bits (encoding A1
than

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/mov-const.ll (right):

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:2: ; ConstantRelocatble (see mov-imm.ll
for the ConstantRelocatable case).
ConstantRelocatable

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:3: 
just use one blank line

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:23: 
single blank line for consistency

[Karl, 2015-11-11 22:47:53]

Committed patchset #3 (id:40001) manually as
5ff0cfb442b666fe435291c25cccae5eacd90ac6 (presubmit successful).

[Karl, 2015-11-11 22:48:19]

https://codereview.chromium.org/1440693002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1440693002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:796: // to handle cases where the constant is greater
tham 16 bits (encoding A1
On 2015/11/11 21:46:39, stichnot wrote:
> than

Done.

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/mov-const.ll (right):

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:2: ; ConstantRelocatble (see mov-imm.ll
for the ConstantRelocatable case).
On 2015/11/11 21:46:39, stichnot wrote:
> ConstantRelocatable

Done.

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:3: 
On 2015/11/11 21:46:39, stichnot wrote:
> just use one blank line

Done.

https://codereview.chromium.org/1440693002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-const.ll:23: 
On 2015/11/11 21:46:39, stichnot wrote:
> single blank line for consistency

Done.